Leahnaya/pokemon-showdown-client
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown-client.git synced 2026-09-10 04:49:14 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Improve App#renameRoom (#1447)

Browse Source 
It was missing some features like updating title bar, autojoins, etc.
This commit is contained in:
Waleed Hassan
2020-01-28 01:33:00 +03:00
committed by Guangcong Luo
parent dcd98ec0b6
commit e7c645647b
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
js/client.js
View File

@@ -879,7 +879,9 @@ function toId() {
self.send('/join ' + roomid);
});
} else if (data === 'rename') {
this.renameRoom(roomid, errormessage);
// |newid|newtitle
var parts = errormessage.split('|');
this.renameRoom(roomid, parts[0], parts[1]);
} else if (data === 'nonexistent' && Config.server.id && roomid.slice(0, 7) === 'battle-' && errormessage) {
var replayid = roomid.slice(7);
if (Config.server.id !== 'showdown') replayid = Config.server.id + '-' + replayid;
@@ -1722,18 +1724,25 @@ function toId() {
if (room.requestLeave && !room.requestLeave(e)) return false;
return this.removeRoom(id);
},
renameRoom: function (id, newid) {
renameRoom: function (id, newid, newtitle) {
var newtitle = newtitle || newid;
var room = this.rooms[id];
if (!room) return false;
if (this.rooms[newid]) {
this.removeRoom(id, true);
return false;
}
this.rooms[newid] = room;
room.id = newid;
room.title = newtitle;
room.$el[0].id = 'room-' + newid;
this.rooms[newid] = room;
delete this.rooms[id];
this.updateLayout();
this.topbar.updateTabbar();
if (this.rooms[newid] === this.curRoom) {
this.updateTitle(this.rooms[newid]);
}
this.updateAutojoin();
},
removeRoom: function (id, alreadyLeft) {
var room = this.rooms[id];