Leahnaya/pokemon-showdown-client
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown-client.git synced 2026-03-21 17:50:29 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update CONTRIBUTING.md

Browse Source
This commit is contained in:
Guangcong Luo 2018-05-14 16:50:56 -05:00 committed by GitHub
parent b3c6c2a308
commit e532df4e6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -18,13 +18,13 @@ This is very restrictive for 2018, but fortunately, with Babel 7 and polyfills,
- no generators or iterables other than `Array` - they either have tons of overhead or are outright unsupported, and this lets us use `for`-`of` on arrays with zero overhead
We have polyfills for:
- `Array#includes` - Note: won't work correctly for -0
- `Array#includes` - Note: won't be able to find `NaN`s
- `String#startsWith`
- `String#endsWith`
- `String#includes`
- `Object.assign`
- `Object.create` - Note: second argument is unsupported
These polyfills are optimized for speed, not spec-compliance. As long as you don't screw around with them, you won't have a problem. Note that `Array#includes` won't work correctly for `NaN` or `-0`.
These polyfills are optimized for speed, not spec-compliance. As long as you don't write very nonstandard code, you won't have a problem.
`Array#includes` is put directly on the `Array` prototype, so you can't use `for-in` on Arrays. Fortunately, TypeScript will complain if you try.