Leahnaya/pokemon-showdown-client
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown-client.git synced 2026-08-25 12:29:57 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix background music stuttering

Browse Source 
I finally got to reading the SM2 documentation more closely, and saw:

> precision can vary between 20 msec to perhaps 0.5 seconds and the
> sound's position property will reflect this delta when the
> onPosition() callback fires

Emphasis on "this.position will reflect this delta".

Anyway, this new system should have significantly less noticeable
stuttering.
This commit is contained in:
Guangcong Luo
2016-12-11 05:29:21 -05:00
parent d66779e7e7
commit 763cfb01f0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
js/battle.js
View File

@@ -92,8 +92,8 @@ var BattleSoundLibrary = (function () {
// suppress crash
return (this.bgmCache[url] = this.soundPlaceholder);
}
this.bgmCache[url].onposition(loopend, function () {
this.setPosition(loopstart);
this.bgmCache[url].onposition(loopend, function (evP) {
this.setPosition(this.position - (loopend - loopstart));
});
return this.bgmCache[url];
};