Commit Graph

195 Commits

Author SHA1 Message Date
Rangi
afd42efb60 Consistent labels for each nickname in RAM 2021-03-17 16:38:30 -04:00
Rangi
d1167570cc Assert some more table widths 2021-03-17 11:37:55 -04:00
Rangi
2bc8cf5fc1 Revise some constant definitions 2021-03-16 18:08:25 -04:00
Rangi
0d185fbd88 Define MAPGROUP_* constants and verify MapGroup_* table sizes 2021-03-10 21:21:12 -05:00
Rangi
472051eb5e Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros 2021-03-05 16:18:43 -05:00
Rangi
5454e1e0de Verify data table sizes with table_width and assert_table_length macros
It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants.
2021-03-05 16:10:25 -05:00
Rangi
edbc734b84 Fix typo 2021-02-05 12:46:34 -05:00
Rangi
4c43fa538d The 'tmhm' macro adjusts to the number of TMs/HMs 2021-01-06 10:20:29 -05:00
Rangi
524f57703f Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
2020-12-23 16:46:49 -05:00
Rangi
79d7682b03 Clarify signed magnitude in the growth_rate macro 2020-12-20 23:35:32 -05:00
Rangi
653e92d803 Use assert to ensure correct base data size 2020-11-17 16:14:41 -05:00
Rangi
ca957dd503 Correct some filename comments 2020-11-17 10:59:56 -05:00
Rangi
dd73b278b5 Resolve some "???" comments 2020-11-17 10:56:28 -05:00
Rangi
dbcab434fb Rename "dummy game" to "memory game" 2020-11-08 19:32:52 -05:00
Rangi
b56c1b6351 More syncing with pokecrystal 2020-11-03 10:12:54 -05:00
Rangi
c9bf53310f Identify an unused intro sprite animation from pokegold-spaceworld 2020-11-02 09:30:29 -05:00
Rangi
a75527df25 Make some labels more consistent 2020-11-01 12:36:53 -05:00
Rangi
eecff60284 UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims 2020-10-30 17:32:04 -04:00
Rangi
6063bd1dfb Identify wSpriteAnimDict key constants 2020-10-30 15:38:56 -04:00
Rangi
b89636769c Updates to more closely sync with pokecrystal 2020-10-29 23:23:44 -04:00
Rangi
7062ce2ffa Identify the remaining uses of another WRAM union 2020-10-29 14:45:52 -04:00
Rangi
b47bfbd813 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:39:52 -04:00
Rangi
9483cf47dd Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:24 -04:00
Rangi
6e142eb5b3 Create data/collision/ for tile collision-related data 2020-10-27 10:00:51 -04:00
Rangi
46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Elliot
3c8bf3c01d
Name symbols in link.asm (#63)
Identify remaining link.asm labels
2020-10-23 13:37:12 -04:00
Rangi
0d681c25b9 Identify some more map object labels and constants 2020-10-22 17:41:42 -04:00
Rangi
0b6b706ffc Identify some more labels (a few link-related) 2020-10-22 00:53:59 -04:00
Rangi
5838d479a2 Identify battle bg effects functions and constants 2020-10-06 16:18:05 -04:00
Rangi
4289216de1 Identify anim object constants 2020-10-04 15:34:31 -04:00
Rangi
ec88087f30 Identify battle animation functions 2020-10-03 22:17:19 -04:00
mid-kid
aa04a13578 GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:17:53 +02:00
Rangi
2556704a43 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:57 -04:00
Rangi
8b40e990d3 Generate the Stadium 2 checksum data with pfero's tool instead of raw INCBINs 2020-07-23 23:49:30 -04:00
Rangi
f9f438473f Move EngineFlags and SpecialsPointers into data/engine/ 2020-07-22 20:25:22 -04:00
Rangi
31287c6aaa Revert "Factor out tables into data/overworld/"
This reverts commit 3f392c2792.
2020-07-22 20:23:19 -04:00
Rangi
3f392c2792 Factor out tables into data/overworld/ 2020-07-22 15:23:02 -04:00
Rangi
53d4a649b9 Treat map setup commands like trade script commands 2020-07-22 13:37:52 -04:00
Rangi
0bb3d0e472 Define NUM_FLYPOINTS 2020-07-21 11:48:46 -04:00
Rangi
a7360edd39 SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE 2020-07-17 13:01:36 -04:00
Rangi
a304573fcb Define map setup commands as macros like other script commands 2020-07-13 20:49:57 -04:00
Rangi
4eeab8973c Disassemble the final English debug ROMs 2020-07-13 10:59:22 -04:00
Rangi
61598ad925 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-09 11:27:10 -04:00
Rangi
e3a815bf4a add_tm and add_hm define TM##_MOVE and HM##_MOVE constants, to avoid repeating the move names in tmhm_moves.asm 2020-07-06 16:49:46 -04:00
Rangi
92f96e8c78 Use STRCMP, not ==, to compare multi-character strings 2020-07-02 11:46:39 -04:00
Rangi
e6f7543292 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:40 -04:00
Rangi
f680408489 Comment more ROM labels as unreferenced
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:40 -04:00
Rangi
9dee89fae3 Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:29 -04:00
Rangi
815d22201a Identify some more Unknown labels 2020-06-20 18:52:20 -04:00
entrpntr
9d0c8dbf8e Rename labels to stop cheating the unnamed.py script. 2020-06-19 07:35:14 -04:00