Commit Graph

65 Commits

Author SHA1 Message Date
Rangi
3affb23969
Don't pass redundant label names to table_width and list_start (#126) 2024-12-27 12:35:41 -05:00
Sylvie
201d12d44e
Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F (#123)
Some checks failed
CI / build (push) Has been cancelled
2024-11-30 17:25:26 -05:00
Sylvie
7ebc4324db
Identify more bit flags (#120)
Some checks are pending
CI / build (push) Waiting to run
2024-11-28 14:50:00 -05:00
Idain
a62dfe8548 Add more assert cases in the codebase (pret/pokecrystal#1115)
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
2024-04-27 12:23:02 -05:00
xCrystal
10d38669b0 In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-30 00:31:05 +01:00
xCrystal
c0812ca008 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-30 00:26:13 +01:00
vulcandth
6805c678ee
Rename SLP to SLP_MASK (#84)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:55 -04:00
vulcandth
464c67ee73
RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
Konrad Borowski
2b6134b436 Remove Heavy Ball never happens comment
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:29 +00:00
Rangi
fddd1c132b Identify some wMenuJoypad-related button constants 2022-03-09 19:42:31 -05:00
Rangi
14a21880a0 Use ~X instead of $ff ^ X 2021-11-23 20:50:17 -05:00
Rangi
afd42efb60 Consistent labels for each nickname in RAM 2021-03-17 16:38:30 -04:00
Rangi
f9431c6aab
Merge pull request #69 from Rangi42/tables
Verify data table sizes with table_width and assert_table_length macros
2021-03-08 07:01:30 -08:00
Rangi
abfe4f96ee Identify scrolling menu lists in WRAM 2021-03-08 09:45:51 -05:00
Rangi
5454e1e0de Verify data table sizes with table_width and assert_table_length macros
It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants.
2021-03-05 16:10:25 -05:00
Rangi
51aa06097f Rename GetFarHalfword to GetFarWord 2021-01-09 15:16:20 -05:00
Rangi
524f57703f Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
2020-12-23 16:46:49 -05:00
Rangi
c745dd6777 FarString -> PlaceFarString, and FarPlaceString -> BrokenPlaceFarString 2020-12-07 13:32:07 -05:00
Rangi
84dd1b587f Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:13 -05:00
Rangi
bc8636d688 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:35 -05:00
Rangi
9281a44c68 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers 2020-11-03 23:25:20 -05:00
Rangi
2b9c37e74f Identify some more uses of wBuffer1-6 2020-11-03 22:45:10 -05:00
Rangi
5c143ed970 Identify more uses of wBuffer1-6 2020-11-03 19:52:59 -05:00
Rangi
b56c1b6351 More syncing with pokecrystal 2020-11-03 10:12:54 -05:00
Rangi
7062ce2ffa Identify the remaining uses of another WRAM union 2020-10-29 14:45:52 -04:00
Rangi
46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Rangi
a325de7630 Identify SwitchItemsInBag labels
Thanks to FIQ for having done so in Polished Crystal
2020-10-21 15:39:19 -04:00
Rangi
d2ffdbf7ea Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:25 -04:00
Rangi
10151dd4eb Identify some more unnamed labels 2020-10-05 20:09:52 -04:00
Rangi
8871f4b611 Identify more unnamed labels 2020-10-05 16:15:47 -04:00
Rangi
e128fbeadb Identify some more unnamed labels 2020-10-04 20:10:31 -04:00
Rangi
34ad9498ea
Merge pull request #60 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:16 -04:00
Rangi
7d8a73220c Factor out gfx/pack/pack_menu.tilemap 2020-08-12 21:02:08 -04:00
mid-kid
2de0ac25f4 Better label 2D menu data 2020-08-04 01:18:00 +02:00
Rangi
4eeab8973c Disassemble the final English debug ROMs 2020-07-13 10:59:22 -04:00
Rangi
a19abb5045 Use const_skip and const_next macros for brevity 2020-07-09 12:15:44 -04:00
Rangi
6595505831 Identify some more labels 2020-06-22 16:29:53 -04:00
Rangi
9dee89fae3 Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:29 -04:00
entrpntr
9d0c8dbf8e Rename labels to stop cheating the unnamed.py script. 2020-06-19 07:35:14 -04:00
Rangi
f8c1754238 Harmonize engine/{gfx, items, link, math} with pokecrystal 2020-06-17 10:39:06 -04:00
Rangi
9f01e33a04 Port miscellaneous recent updates from pokecrystal 2020-06-15 13:12:56 -04:00
entrpntr
e28325211c Fix file permissions. 2020-06-05 16:42:33 -04:00
entrpntr
3e40a1ecd0 Simple cleanups in constants/data/macros and banks 1-4. 2020-05-12 13:31:27 -04:00
entrpntr
858f7a0b8a Finish cleanup of bank 3. 2020-05-04 16:23:03 -04:00
entrpntr
fd35959d94 Clean up text, and some bank 3 code. 2020-05-04 14:25:55 -04:00
entrpntr
3d651a7c49 Add Makefile option for verbose sym/map; fix some label names. 2020-05-03 04:41:05 -04:00
entrpntr
9b5b2ac809 Disassemble bank $0b. 2020-05-01 20:56:15 -04:00
entrpntr
35f6c55eac Add remaining bank 9 files. 2020-04-30 00:47:14 -04:00
entrpntr
a308a1adad Add bank 9 files before trainer card. 2020-04-29 18:48:23 -04:00
entrpntr
d53f3afe50 Clean up some overworld code. 2020-04-26 22:15:31 -04:00