Commit Graph

96 Commits

Author SHA1 Message Date
Rangi
d2c9e2d74f
Use features of RGBDS 1.0.0 (#138)
Some checks are pending
CI / build (push) Waiting to run
2025-11-12 15:44:00 -05:00
Rangi42
b03ba1a549 Update hardware.inc to 5.1.0 2025-06-30 12:47:34 -04:00
Rangi
f57be98873
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#130) 2025-06-23 09:11:35 -04:00
Rangi42
81a1dc3e18 Use SIZEOF/STARTOF from RGBDS 0.7.0 2025-03-15 00:39:08 -04:00
Rangi42
359d7ae325 Separate constants for name types and naming screen types 2025-03-14 21:44:48 -04:00
Rangi
3affb23969
Don't pass redundant label names to table_width and list_start (#126) 2024-12-27 12:35:41 -05:00
Sylvie
201d12d44e
Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F (#123)
Some checks failed
CI / build (push) Has been cancelled
2024-11-30 17:25:26 -05:00
Sylvie
7ebc4324db
Identify more bit flags (#120)
Some checks are pending
CI / build (push) Waiting to run
2024-11-28 14:50:00 -05:00
xCrystal
f035cd599c Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-30 00:35:14 +01:00
xCrystal
10d38669b0 In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-30 00:31:05 +01:00
xCrystal
aac0d97362 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
2024-01-30 00:27:27 +01:00
xCrystal
c0812ca008 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-30 00:26:13 +01:00
vulcandth
70f883dc86 Sync sprite and battle anim consts/labels (pret/pokecrystal#1055)
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 14:48:08 -05:00
Idain
63d552f6e5 Replace magic numbers with TILE_WIDTH (pret/pokecrystal#1056)
* Replace magic numbers with TILE_WIDTH

* Address more instances
2023-07-27 10:51:54 -05:00
Rangi
0bccfa1cd1 Use for loops to generate box pointer tables 2022-09-10 13:58:48 -04:00
Rangi
659e083376 Move non-Pokémon graphics out of gfx/icons 2022-08-17 17:45:28 -04:00
vulcandth
2dacdbf926 Bug Doc: Options menu fails to clear joypad state on initialization 2022-08-11 23:36:33 -05:00
Rangi
902445d353
Refer to "Rival", not "Silver" (#103)
See https://github.com/pret/pokecrystal/pull/983
2022-08-10 21:24:58 -04:00
Rangi
22ff80f0fb Assert that there are NUM_FRAMES textbox frames 2022-08-06 12:26:09 -04:00
Colton G. Rushton
99fd84eba6
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#99) 2022-07-09 17:18:21 -04:00
vulcandth
464c67ee73
RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
vulcandth
2bab8a2946
Improved Virtual Console patch identifiers (#79) 2022-06-06 17:22:43 -04:00
vulcandth
3d58fb9556
Build the Virtual Console patches with make gold_vc and make silver_vc (#74) 2022-03-14 17:03:15 -04:00
Rangi
14a21880a0 Use ~X instead of $ff ^ X 2021-11-23 20:50:17 -05:00
Rangi
43f9f529fa Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:57:58 -04:00
Rangi
40dbe0df04 Use rgbds 0.5.0 2021-04-20 21:17:09 -04:00
Rangi
381a4b443b Assert the sBox1-14 tables have NUM_BOXES entries 2021-03-21 17:47:50 -04:00
Rangi
524f57703f Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
2020-12-23 16:46:49 -05:00
Rangi
ca957dd503 Correct some filename comments 2020-11-17 10:59:56 -05:00
Rangi
bc8636d688 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:35 -05:00
Rangi
5c143ed970 Identify more uses of wBuffer1-6 2020-11-03 19:52:59 -05:00
Rangi
6063bd1dfb Identify wSpriteAnimDict key constants 2020-10-30 15:38:56 -04:00
Rangi
b47bfbd813 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:39:52 -04:00
Rangi
9483cf47dd Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:24 -04:00
Rangi
599046c892 Identify remaining Mystery Gift labels and constants
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
2020-10-27 23:08:46 -04:00
Rangi
46f6cc4d41 Comment, remove, or revise many unreferenced labels 2020-10-26 20:30:09 -04:00
Rangi
8b766163e3 Identify some unnamed labels 2020-10-06 13:49:55 -04:00
Rangi
054e6088f9 Identify some more unnamed labels 2020-10-05 12:02:48 -04:00
Rangi
3745ba9f9e Identify more unnamed labels 2020-10-04 22:34:55 -04:00
Rangi
e128fbeadb Identify some more unnamed labels 2020-10-04 20:10:31 -04:00
mid-kid
0a1eb668d0 Fix some constants surrounding sprite animations
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 14:51:59 +02:00
mid-kid
a7c294371c Port splash screen documentation changes from Crystal
Since the splash screen is wildly different, a lot of the docs don't
really apply here.
2020-08-27 14:40:18 +02:00
mid-kid
4ea75afd56 Add wTitleScreenSelectedOption constants 2020-08-18 22:28:22 +02:00
mid-kid
6b2a0b2889 Document wTitleScreenSelectedOption variable 2020-08-05 16:02:23 +02:00
Rangi
878e0b3b33 Identify constant in NamingScreen_IsTargetBox 2020-08-03 15:22:11 -04:00
Rangi
4eeab8973c Disassemble the final English debug ROMs 2020-07-13 10:59:22 -04:00
Rangi
e6f7543292 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:40 -04:00
Rangi
9dee89fae3 Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:29 -04:00
Rangi
e87159ed7b Harmonize engine/menus with pokecrystal 2020-06-18 10:11:03 -04:00
Rangi
451f529b0d Harmonize engine/{movie, pokemon} with pokecrystal
To do: engine/{menus, overworld}
2020-06-17 17:02:45 -04:00