Leahnaya/pokegold
1
0
Fork 0
mirror of https://github.com/pret/pokegold.git synced 2026-04-26 01:47:27 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
995 Commits 2 Branches 0 Tags 21 MiB
master
Commit Graph

273 Commits

Author SHA1 Message Date
mid-kid
09d2148d6d
Use separate constants for wChosenCableClubRoom (#144)
Some checks failed
CI / build (push) Has been cancelled
Details
CI / build-macos (push) Has been cancelled
Details 
These numbers aren't related to the LINK_ values at all, it's just a
coincidence.

Changing these is an easy way for games to force incompatibility with
the original game.
 2026-02-08 13:47:25 -05:00
Rangi
ec8bd3e1ae Verify that only one of each callback type exists per map 
Fixes #1213
 2026-01-20 19:09:30 -05:00
Rangi42
33df401392 Identify JOYP_SGB_MLT_REQ constant
Some checks failed
CI / build (push) Has been cancelled
Details
2025-08-11 16:36:33 -04:00
Rangi42
a17b2c580e Update hardware.inc to 5.3.0 and use its new constants
Some checks are pending
CI / build (push) Waiting to run
Details
2025-08-11 15:56:17 -04:00
Rangi42
0b8a81212e Update hardware.inc to 5.2.0
Some checks failed
CI / build (push) Has been cancelled
Details
2025-07-22 11:57:38 -04:00
Rangi42
b03ba1a549 Update hardware.inc to 5.1.0 2025-06-30 12:47:34 -04:00
Rangi42
8d9317abd7 Address some feedback on hardware.inc
Some checks failed
CI / build (push) Has been cancelled
Details
2025-06-23 10:44:16 -04:00
Rangi
f57be98873
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#130) 2025-06-23 09:11:35 -04:00
Rangi42
9a798b0137 Use offsets from ANIM_* constants for wBattleAfterAnim (formerly wNumHits) 2025-05-31 15:22:54 -04:00
Rangi42
4be4d4708e Define constants for wBillsPCPokemonList entries 2025-05-31 15:17:06 -04:00
Rangi42
24db8a0183 Add a CANNOT_MOVE constant 2025-05-31 15:12:11 -04:00
Rangi42
897dda77bd Verify the battle BG effect pointer table length
Some checks failed
CI / build (push) Has been cancelled
Details
2025-03-15 01:22:56 -04:00
Rangi42
a7fb4e069e Sync further with pokecrystal 2025-03-15 01:03:21 -04:00
Rangi42
bd94c01a44 Verify the trade dialog pointer table length 2025-03-15 00:49:22 -04:00
Rangi42
5032f98fac Verify the mart types pointer table length 2025-03-15 00:44:27 -04:00
Rangi42
81a1dc3e18 Use SIZEOF/STARTOF from RGBDS 0.7.0 2025-03-15 00:39:08 -04:00
Rangi42
de5130c128 Name the unused engine flags according to their bit constants 2025-03-14 23:31:43 -04:00
Rangi42
359d7ae325 Separate constants for name types and naming screen types 2025-03-14 21:44:48 -04:00
Rangi42
2571edf37b Avoid using EQUS when EQU or MACRO will do 2025-03-14 21:38:49 -04:00
Rangi
54b8389023
Identify CHANNEL_FIELD16 as CHANNEL_NOTE_DURATION_MODIFIER (#117) 2024-12-27 12:54:28 -05:00
mid-kid
7884b88a09 Re-align trainer_data_constants.asm with pokecrystal
Some checks are pending
CI / build (push) Waiting to run
Details
2024-12-25 12:21:34 +01:00
Rangi42
8308f119a3 Remove Crystal-only flag constants
Some checks failed
CI / build (push) Has been cancelled
Details
2024-12-02 12:21:31 -05:00
Sylvie
201d12d44e
Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F (#123)
Some checks failed
CI / build (push) Has been cancelled
Details
2024-11-30 17:25:26 -05:00
Rangi42
9b19999aee Some formatting cleanup 2024-11-28 22:02:24 -05:00
Sylvie
7ebc4324db
Identify more bit flags (#120)
Some checks are pending
CI / build (push) Waiting to run
Details
2024-11-28 14:50:00 -05:00
Rangi42
ffe649f856 Rename Bill's brother to Bill's older sister 2024-10-17 17:27:13 -04:00
Rangi42
96317544e5 Remove Crystal-only mail nationality 2024-09-26 00:34:38 -04:00
Rangi42
0d3575ce8e Rename wram_constants.asm to ram_constants.asm 2024-05-22 21:07:42 -04:00
Rangi42
1675a00a42 Use constants for VBlank handlers 2024-05-22 21:02:56 -04:00
SnorlaxMonster
144133d98e Rename MON_ID to MON_OT_ID (pret/pokecrystal#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2024-04-27 12:21:32 -05:00
vulcandth
202797a008 Fix/update sprite y-coord offscreen definitions (pret/pokecrystal#1108) 2024-04-14 16:09:18 -05:00
xCrystal
df10c9ea1a Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-30 00:41:51 +01:00
xCrystal
f035cd599c Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-30 00:35:14 +01:00
xCrystal
aac0d97362 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
 2024-01-30 00:27:27 +01:00
xCrystal
c0812ca008 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-30 00:26:13 +01:00
Rangi42
16571da5eb Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names 2024-01-01 21:58:26 -05:00
vulcandth
7301cf40de Move charmap.asm to constants/ 
Resolves #1090
 2023-11-17 22:03:29 -06:00
vulcandth
70f883dc86 Sync sprite and battle anim consts/labels (pret/pokecrystal#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 14:48:08 -05:00
Tiddlywinks
1a5c2b0414 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:07:13 +02:00
SoupPotato
97a3786fc8 Labeled framesets and related constants (pret/pokecrystal#1063) 
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-08-21 19:11:14 -05:00
vulcandth
51a98ac773 Define relationship between map_object and object_events (pret/pokecrystal#1054) 2023-08-14 14:20:46 +00:00
SnorlaxMonster
a4aa97213d Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (pret/pokecrystal#1058) 
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-07-27 10:53:25 -05:00
vulcandth
3edd4eb48d Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (pret/pokecrystal#1053) 2023-06-01 12:54:49 +00:00
mid-kid
4cd953c1e5 Define SERIAL_PATCH_PREAMBLE_LENGTH 
Crystal: 86cc644b970eecfb616b858ad8b697f9a09f57eb
 2023-04-19 19:11:15 +02:00
mid-kid
7050425c82 Document link patch lists a little bit better 
Crystal: c8738a3aaecacd1ceec96bc6ccd80592f44de0fc
 2023-04-19 19:09:25 +02:00
mid-kid
bbc7261da2 IsMailEuropean → ParseMailLanguage (and give it constants) 
Crystal: c012a77e83b2a2efa7ade90b18a5a10d57900327
 2023-04-19 19:06:48 +02:00
vulcandth
d36f220b90 Relabel some map_object struct fields 2023-01-03 22:15:15 -06:00
Rangi
be34ff7c09 Dance Theatre -> Dance Theater 2022-09-23 22:17:03 -04:00
Idain
562041b4a2 TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:03:43 -05:00
Rangi
bdb6ae85e0
Rename the object_struct field labels and constants (#105) 2022-09-12 09:15:49 -04:00