Martin Griffin
5a9f566bbd
Minor cleanups ( #2318 )
...
* Cleanup commas in .macro
* Cleanup src/item_use.c post #2313
* Cleanup src/fieldmap.c post #2314
* s/int/s32/g in fieldmap.h/fieldmap.c
* Cleanup src/battle_pyramid.c post #2310
* Cleanup src/battle_anim_effects_2.c post #2266
2026-06-17 15:36:35 +01:00
AZero13
5b621f1819
Fix MoveItemSlotInList fakematch ( #2260 )
...
Co-authored-by: AZero13 <83477269+SiliconA-Z@users.noreply.github.com>
2026-06-17 14:48:29 +01:00
Martin Griffin
059268950f
s/int/s32/g in fieldmap.h/fieldmap.c
2026-06-17 14:35:40 +01:00
AZero13
80f23292d2
Make data1 and learnMoveState an array to prevent UB ( #2284 )
...
Fixes https://github.com/pret/pokeemerald/issues/2102
2026-06-17 14:09:24 +01:00
AZero13
305a831b2d
Use DMA Macros more consistently ( #2309 )
...
I also had to move the check to first for some places to match.
Co-authored-by: Mike-Goutokuji <83477269+mike-goutokuji@users.noreply.github.com>
2026-06-17 11:51:53 +01:00
AZero13
2da84f7e3c
Simplify and const-correct fieldmap.c ( #2314 )
...
Changing MapGridGetMetatileIdAt to output int also reduces number of casts
Co-authored-by: Mike-Goutokuji <83477269+mike-goutokuji@users.noreply.github.com>
2026-06-17 11:37:16 +01:00
Estellar
0eda6d14e9
Add TextPrinterCallback ( #2306 )
CI / build (push) Has been cancelled
2026-06-11 18:54:19 +01:00
FosterProgramming
4b6a69ae24
Rename daycare special to account for string side effects ( #2287 )
CI / build (push) Waiting to run
2026-06-04 12:08:01 +01:00
FosterProgramming
0d3100185e
Rename mass outbreak show to distinguish from savefile outbreakDaysLeft ( #2288 )
CI / build (push) Has been cancelled
2026-05-15 21:51:57 -04:00
Martin Griffin
98ed1a6e6e
Merge pull request #2140 from AsparagusEduardo/_pret/BtlController_EmitTwoReturnValues
...
`BtlController_EmitTwoReturnValues` cleanup
2026-04-21 16:01:35 +01:00
Martin Griffin
c314cc1e52
Merge pull request #2231 from GriffinRichards/match-call-rematch
...
Document gym leader match call texts
2026-04-21 15:57:49 +01:00
Martin Griffin
1dcb9c75b9
Merge pull request #2212 from Mitsunee/ismondisobedient-enum
...
Added enum for IsMonDisobedient
2026-04-21 15:57:06 +01:00
Raymond Dodge
a09b745176
Extract GiveGiftRibbonToParty from file about size records ( #2240 )
2026-04-21 15:52:51 +01:00
Raymond Dodge
31552457e0
Merge pull request #2241 from rayrobdod/compare_size_return_names
...
Name values used by CompareMonSize
2026-04-21 15:52:36 +01:00
Marky
25ffb2c12c
Add enum for Elevations ( #2233 )
CI / build (push) Has been cancelled
2026-02-20 01:17:42 -05:00
Frank DeBlasio
064ca5c243
Added macro for Surf/Muddy Water's animation ( #2232 )
CI / build (push) Has been cancelled
2026-02-06 10:08:20 -05:00
GriffinR
926488b69a
Document gym leader match call texts
2026-02-01 13:36:33 -05:00
Martin Griffin
e09423fadf
Document battle_anim_normal.c
2026-01-19 09:16:37 +00:00
Bassoonian
a5ee0f2727
ItemTMHMOrEvolutionStone enum ( #2192 )
2026-01-02 20:59:12 +00:00
cawtds
b11741855d
Add enum for battle script opcodes ( #2222 )
2026-01-02 20:19:01 +00:00
Josh
349da0484b
Document m4a xcmd_0C
2025-12-27 01:11:40 +00:00
Mitsunee
02c44242f8
Added bugfix for missing no weather case in Cmd_weather_get ( #2203 )
CI / build (push) Has been cancelled
2025-12-09 22:22:08 -05:00
GriffinR
f0e351b33d
Merge pull request #2171 from ShinyDragonHunter/unused_funcs
...
Label unused functions in siirtc.c, m4a.c & rtc.c with the "UNUSED" attribute
2025-12-09 22:14:57 -05:00
GriffinR
bcd5735f76
Merge pull request #2176 from NTx86/gba-fix-object-event-range-type
...
Change rangeX and rangeY to u8 in ObjectEvent struct
2025-12-09 21:57:06 -05:00
GriffinR
83b05d5efa
Merge pull request #2201 from mrgriffin/pret-flag-registered-wally
...
Fix FLAG_REGISTERED_WALLY
2025-12-09 21:43:30 -05:00
mitsunee
8797a07e55
Added enum for IsMonDisobedient
2025-11-29 11:22:16 +01:00
mitsunee
c0569cd529
Standardize spelling of "synchronize"
2025-11-19 21:14:45 +01:00
mitsunee
73ec0813e1
Standardize spelling of "canceler"
...
just a quick grep -r and regex substitution, but didn't see anything wrong in the diffs during a quick proofread
2025-11-15 12:11:32 +01:00
Martin Griffin
c466dce996
Fix FLAG_REGISTERED_WALLY
2025-11-06 13:40:22 +00:00
Martin Griffin
d1d5435487
Improve undefined map assembler messages ( #2196 )
CI / build (push) Has been cancelled
2025-10-29 21:34:03 -04:00
DavidJCobb
7fd0029ed7
Add typedefs for MAPSEC and METLOC values ( #2183 )
...
Added typedefs: mapsec_t, metloc_t, and variants for MAPSEC and METLOC values. There are some rough edges that could do with smoothing out, but for now, this gets us close to ideal with a ROM that compares equal.
Per feedback, all typedefs to mention the underlying type within the typedef name. The documentation comments reflect and explain the naming convention.
Updated comments to reflect the fact that we're no longer using SET8 for a Pokemon's met locations, in favor of a new macro (added by this PR) that adjusts to match the width of whatever is being set.
2025-10-19 17:37:13 +01:00
Estellar
0965dffe70
Use TaskFunc wherever posible ( #2188 )
CI / build (push) Waiting to run
2025-10-18 17:53:50 +01:00
Estellar
f4f7c38255
Use MainCallback wherever posible ( #2184 )
2025-10-14 09:41:27 +01:00
NT_x86
d6714add6f
Change rangeX and rangeY to u8 in ObjectEvent struct
2025-08-31 20:36:09 +03:00
Alex
208f97e1e3
Rename passive damage hitmarker ( #2174 )
CI / build (push) Has been cancelled
2025-08-21 13:43:19 +01:00
Josh
6cc878919d
Identify unused functions in siirtc.c, m4a.c & rtc.c
...
"SiiRtcSetAlarm" in siirtc.c, the "FormatHex" functions in rtc.c and "UnusedDummyFunc", m4aSongNumStartOrContinue", m4aSongNumContinue", "MusicPlayerJumpTableCopy" in m4a.c are all unused in vanilla so they've been changed to use the "UNUSED" attribute.
2025-08-09 20:57:59 +01:00
Josh
0dfec24967
Allow names for voicegroups and use a macro for use with drumsets ( #2149 )
...
CI / build (push) Has been cancelled
mid2agb has been modified to allow more than just numbers when naming voicegroups and voicegroups have been renamed to match. A "voice_group" macro has been set up with a optional parameter for the starting note will shift the offset by the specified amount * 0xC which is the length of 1 voice in a voicegroup. All drumset voicegroups have a "starting_note" of 36.
2025-07-30 19:43:08 +01:00
GriffinR
6f8a1bbdb8
Add pack/unpack for data masks ( #2163 )
CI / build (push) Has been cancelled
2025-07-23 09:28:34 +01:00
Raymond Dodge
80b9c23d0a
Fix RL compressed data alignment
...
`RLUnComp`, like `LZ77UnComp`, expects the source data to be word-aligned.
So, to mirror how lz-compressed data is defined as `u32[]` to enforce
word-alignment, this changes rl-compressed data to be defined as `u32[]`
to enforce word-alignment.
2025-07-06 13:49:47 -04:00
GriffinR
0c7c81e02f
Merge branch 'master' into _pret/pr/pyramidLocation
2025-06-30 11:51:45 -04:00
DizzyEggg
e1b83d6056
Match graphics declarations with externs ( #2089 )
CI / build (push) Has been cancelled
2025-06-23 20:31:18 +01:00
DizzyEggg
53f8ae11ff
Move gTradePlatform_Tilemap to header ( #2088 )
2025-06-22 19:48:37 -04:00
cawtds
0fc900514b
sync list menu functions with firered
2025-06-02 22:51:26 +02:00
GriffinR
0c32d840fa
Merge pull request #2141 from pret/porymap-6
...
Update for Porymap 6
2025-05-27 10:53:17 -04:00
Alex
b31a73f990
Rename ItemId_GetX to GetItemX ( #2116 )
2025-05-22 13:27:52 +01:00
Kurausukun
bd0a02c456
Correct C23 Checks ( #2144 )
CI / build (push) Has been cancelled
2025-05-19 15:43:06 +01:00
Bassoonian
59d315734d
Update header files to match source files ( #2143 )
2025-05-19 09:18:04 +01:00
Kurausukun
e1e7d1cf35
Fixes for C23 Support ( #2138 )
...
CI / build (push) Waiting to run
* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include
2025-05-19 09:11:59 +01:00
Bassoonian
16357c7e29
Streamline pointer notation ( #2139 )
CI / build (push) Has been cancelled
2025-05-16 12:04:44 +01:00
Eduardo Quezada
d39e0bb3c8
BtlController_EmitTwoReturnValues cleanup
2025-05-14 14:42:32 -04:00
