Leahnaya/pokeemerald
1
0
Fork 0
mirror of https://github.com/pret/pokeemerald.git synced 2026-03-21 17:54:57 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #2137 from mrgriffin/pret-suspicious-setvar
Some checks are pending
CI / build (push) Waiting to run
Details

Browse Source 
Warn on suspicious setvar usages
This commit is contained in:
GriffinR 2025-05-15 17:21:00 -04:00 committed by GitHub
commit 74bf498aaa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
asm/macros/event.inc
View File

@ -145,7 +145,10 @@
.endm
@ Changes the value of destination to value.
.macro setvar destination:req, value:req
.macro setvar destination:req, value:req, warn=TRUE
.if \warn && ((\value >= VARS_START && \value <= VARS_END) || (\value >= SPECIAL_VARS_START && \value <= SPECIAL_VARS_END))
.warning "setvar with a value that might be a VAR_ constant; did you mean copyvar instead?"
.endif
.byte SCR_OP_SETVAR
.2byte \destination
.2byte \value