ede39900dd
The test used HP_BAR(player) to capture damage, but when a Substitute absorbs a hit the battle engine fires a SUB_HIT event, not an HP_BAR event. The drain logic already uses INCLUDING_SUBSTITUTES so the heal fired correctly. Fix by switching to SUB_HIT(player, captureDamage: &damage) and changing damage to u16 to match SubHitEventContext. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> |
||
|---|---|---|
| .github | ||
| asm | ||
| constants | ||
| data | ||
| dev_scripts | ||
| docs | ||
| graphics | ||
| include | ||
| libagbsyscall | ||
| migration_scripts | ||
| sound | ||
| src | ||
| test | ||
| tools | ||
| .all-contributorsrc | ||
| .gitattributes | ||
| .gitignore | ||
| asmdiff.ps1 | ||
| asmdiff.sh | ||
| audio_rules.mk | ||
| build_tools.sh | ||
| CHANGELOG.md | ||
| charmap.txt | ||
| check_history.sh | ||
| config.mk | ||
| CONTRIBUTING.md | ||
| CREDITS.md | ||
| FEATURES.md | ||
| graphics_file_rules.mk | ||
| INSTALL.md | ||
| json_data_rules.mk | ||
| ld_script_modern.ld | ||
| ld_script_test.ld | ||
| make_tools.mk | ||
| Makefile | ||
| map_data_rules.mk | ||
| README.md | ||
| rom.sha1 | ||
| spritesheet_rules.mk | ||
| trainer_rules.mk | ||
About pokeemerald-expansion
pokeemerald-expansion is a GBA ROM hack base that equips developers with a comprehensive toolkit for creating Pokémon ROM hacks. pokeemerald-expansion is built on top of pret's pokeemerald decompilation project. It is not a playable Pokémon game on its own.
Features
pokeemerald-expansion offers hundreds of features from various core series Pokémon games, along with popular quality-of-life enhancements designed to streamline development and improve the player experience. A full list of those features can be found in FEATURES.md.
Credits
If you use pokeemerald-expansion, please credit RHH (Rom Hacking Hideout). Optionally, include the version number for clarity.
Based off RHH's pokeemerald-expansion 1.15.0 https://github.com/rh-hideout/pokeemerald-expansion/
Please consider crediting all contributors involved in the project!
Choosing pokeemerald or pokeemerald-expansion
pokeemerald-expansionsupports multiplayer functionality with other games built onpokeemerald-expansion. It is not compatible with official Pokémon games.- If compatibility with official games is important, use
pokeemerald. Otherwise, we recommend usingpokeemerald-expansion. pokeemerald-expansionincorporates regular updates frompokeemerald, including bug fixes and documentation improvements.
Getting Started
❗❗ Important: Do not use GitHub's "Download Zip" option as it will not include commit history. This is necessary if you want to update or merge other feature branches.
If you're new to git and GitHub, Team Aqua's Asset Repo has a guide to forking and cloning the repository. Then you can follow one of the following guides:
📥 Installing pokeemerald-expansion
🏗️ Building pokeemerald-expansion
🚚 Migrating from pokeemerald
🚀 Updating pokeemerald-expansion
Documentation
For detailed documentation, visit the pokeemerald-expansion documentation page.
Contributions
If you are looking to report a bug, open a pull request, or request a feature, our CONTRIBUTING.md has guides for each.
Community
Our community uses the ROM Hacking Hideout (RHH) Discord server to communicate and organize. Most of our discussions take place there, and we welcome anybody to join us!