Leahnaya/pokeemerald-expansion
1
0
Fork 0
mirror of https://github.com/rh-hideout/pokeemerald-expansion.git synced 2026-03-21 18:04:50 -05:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix Dream Eater Substitute test (Gen 5+)

Browse Source 
The test used HP_BAR(player) to capture damage, but when a Substitute
absorbs a hit the battle engine fires a SUB_HIT event, not an HP_BAR
event. The drain logic already uses INCLUDING_SUBSTITUTES so the heal
fired correctly. Fix by switching to SUB_HIT(player, captureDamage:
&damage) and changing damage to u16 to match SubHitEventContext.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Nephrite 2026-03-21 14:28:34 +00:00
parent 78dbb87179
commit ede39900dd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/battle/move_effect/dream_eater.c
View File

@ -94,9 +94,9 @@ SINGLE_BATTLE_TEST("Dream Eater fails if the target is behind a Substitute (Gen
#else
SINGLE_BATTLE_TEST("Dream Eater works if the target is behind a Substitute (Gen 5+)")
{
s16 damage;
u16 damage;
s16 healed;
KNOWN_FAILING; // Dream Eater can hit and drain from a Substitute, but not bypass it.
// Dream Eater can hit and drain from a Substitute, but not bypass it.
GIVEN {
ASSUME(GetMoveEffect(MOVE_YAWN) == EFFECT_YAWN);
ASSUME(GetMoveEffect(MOVE_SUBSTITUTE) == EFFECT_SUBSTITUTE);
@ -108,7 +108,7 @@ SINGLE_BATTLE_TEST("Dream Eater works if the target is behind a Substitute (Gen
TURN { MOVE(opponent, MOVE_DREAM_EATER); }
} SCENE {
ANIMATION(ANIM_TYPE_MOVE, MOVE_DREAM_EATER, opponent);
HP_BAR(player, captureDamage: &damage);
SUB_HIT(player, captureDamage: &damage);
HP_BAR(opponent, captureDamage: &healed);
} THEN {
EXPECT_MUL_EQ(damage, Q_4_12(-1.0/2.0), healed);