address review comments

This commit is contained in:
Seth Barberee
2021-05-15 20:30:26 -05:00
parent 5d6018d667
commit 5f4bb52fd5
6 changed files with 14 additions and 13 deletions

View File

@@ -1,7 +1,8 @@
#ifndef NITRO_RTC_INTERNAL_H_
#define NITRO_RTC_INTERNAL_H_
BOOL RtcSendPxiCommand(u8 command);
#include "nitro/types.h"
BOOL RTCi_WriteRawStatus2Async(void);
BOOL RTCi_ReadRawTimeAsync(void);
BOOL RTCi_ReadRawDateAsync(void);

View File

@@ -1,28 +1,30 @@
#include "global.h"
#include "function_target.h"
#include "PXI_fifo.h"
#include "RTC_internal.h"
BOOL RTCi_ReadRawDateTimeAsync(void)
static BOOL RtcSendPxiCommand(u8 command);
ARM_FUNC BOOL RTCi_ReadRawDateTimeAsync(void)
{
return RtcSendPxiCommand(16);
}
BOOL RTCi_ReadRawDateAsync(void)
ARM_FUNC BOOL RTCi_ReadRawDateAsync(void)
{
return RtcSendPxiCommand(17);
}
BOOL RTCi_ReadRawTimeAsync(void)
ARM_FUNC BOOL RTCi_ReadRawTimeAsync(void)
{
return RtcSendPxiCommand(18);
}
BOOL RTCi_WriteRawStatus2Async(void)
ARM_FUNC BOOL RTCi_WriteRawStatus2Async(void)
{
return RtcSendPxiCommand(39);
}
BOOL RtcSendPxiCommand(u8 command)
ARM_FUNC static BOOL RtcSendPxiCommand(u8 command)
{
s32 data = command << 8 & 0x7f00;
return PXI_SendWordByFifo(PXI_FIFO_TAG_RTC, data, FALSE) >= 0;

View File

@@ -1,4 +1,4 @@
#include "global.h"
#include "function_target.h"
#include "WIFI_stubsmd5_dummy.h"
ARM_FUNC void MD5Final(u8 *digest, struct DGTHash1Context *context)

View File

@@ -26,7 +26,7 @@ THUMB_FUNC u8 *LoadHallOfFame(struct SaveBlock2 *sav2, u32 heap_id, int *ret_p)
return ReadSaveFileFromFlash(sav2, heap_id, 0, ret_p);
}
THUMB_FUNC int *SaveHallOfFame(struct SaveBlock2 *sav2, u8 *data)
THUMB_FUNC s32 *SaveHallOfFame(struct SaveBlock2 *sav2, u8 *data)
{
return WriteSaveFileToFlash(sav2, 0, data);
}

View File

@@ -1,12 +1,11 @@
#ifndef POKEDIAMOND_WIFI_STUBSMD5_DUMMY_H
#define POKEDIAMOND_WIFI_STUBSMD5_DUMMY_H
#include "nitro/types.h"
#include "dgt.h"
void MD5Final(u8 *digest, struct DGTHash1Context *context);
void MD5Update(struct DGTHash1Context *context, u8 *input, u32 length);
void MD5Init(struct DGTHash1Context *context);
#endif //POKEDIAMOND_WIFI_STUBSMD5_DUMMY_H

View File

@@ -9,7 +9,6 @@ struct PCStorage *GetStoragePCPointer(struct SaveBlock2 *sav2);
void *FUN_0202251C(struct SaveBlock2 *sav2);
void *FUN_02022528(struct SaveBlock2 *sav2);
u8 *LoadHallOfFame(struct SaveBlock2 *sav2, u32 heap_id, int *ret_p);
int *SaveHallOfFame(struct SaveBlock2 *sav2, u8 *data);
s32 *SaveHallOfFame(struct SaveBlock2 *sav2, u8 *data);
#endif //POKEDIAMOND_UNK_02022504_H