Commit Graph

263 Commits

Author SHA1 Message Date
SnorlaxMonster
2ad9616586
Fix dead/broken URLs (#1225)
Some checks failed
CI / build (push) Has been cancelled
CI / build-macos (push) Has been cancelled
2026-01-24 15:44:26 -05:00
SnorlaxMonster
7c3d2956cd
Consistently use Japanese control codes for Japanese strings (#1222) 2026-01-24 15:37:50 -05:00
abcboy101
619339d589
Consistently use <GA> for $4a in Japanese strings (#1218) 2026-01-05 22:47:01 -05:00
Rangi
a55bc33d67
Use features of RGBDS 1.0.0 (#1204)
Some checks are pending
CI / build (push) Waiting to run
- Use single-quoted character literals or `CHARVAL` when you need
  a character's numeric value; using strings as numbers is deprecated
- Use `?` to silence a node in warning/error location backtraces
- Use `===` and `!==` instead of `STRCMP`, and `++` instead of `STRCAT`
- Use `__SCOPE__` instead of checking for `..` and `.` separately
- Use `#string` instead of `"{string}"`
- All programs (rgbasm, rgblink, rgbfix, rgbgfx) support `-W` warnings
- `rgbgfx --colors dmg` is short for `rgbgfx --colors dmg=e4`
2025-11-12 15:43:54 -05:00
Rangi
86acbe5b55
Use dname macro to automatically pad names with "@" characters (#1198)
Some checks failed
CI / build (push) Has been cancelled
2025-08-17 09:48:05 -04:00
Rangi42
5abf8d01fb Update hardware.inc to 5.1.0 2025-06-30 12:47:36 -04:00
Brianum
8f5a8c5b5b
Identify wCrystalData's content and rename memory locations accordingly (#1191) 2025-06-30 11:37:37 -04:00
Rangi
4c540aa43b
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#1186) 2025-06-23 09:11:33 -04:00
Rangi
85ddf0e90a
Don't pass redundant label names to table_width and list_start (#1160) 2024-12-27 12:35:35 -05:00
Rangi
61c9ba5f6c
Use RGBDS 0.9.0 (#1159)
Some checks are pending
CI / build (push) Waiting to run
2024-12-25 21:24:37 -05:00
Rangi42
03a1c6efad Mobile jumptable exit bits 2024-12-02 12:16:30 -05:00
Sylvie
644bd42fb0
Identify more bit flags (#1153)
Some checks failed
CI / build (push) Has been cancelled
2024-11-29 19:29:30 -05:00
Sylvie
2265e53d24
Rename dt and dd to bigdt and bigdd (#1141)
Some checks are pending
CI / build (push) Waiting to run
This makes their big-endianness obvious and matches `bigdw`
2024-10-17 14:52:47 -04:00
Sylvie
8819f7b117
Identify various "????"s (#1125) 2024-06-11 20:54:45 -04:00
Rangi42
b81e339f33 Use constants for VBlank handlers 2024-05-22 21:02:55 -04:00
xCrystal
7f3b87950a more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
xCrystal
f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal
5be9856f3a In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
xCrystal
bd6ceec193 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-07 13:36:05 +01:00
Rangi
dbf6044650
Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
SnorlaxMonster
a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
Idain
2907d65a47
Improve use of palette macro and use PAL_* constants (#1087)
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 12:24:09 -06:00
vulcandth
aba1f14044
Sync sprite and battle anim consts/labels (#1055)
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 13:09:28 -05:00
SatoMew
768b3bdec1
Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
Idain
94df3c5aa3
Replace magic numbers with TILE_WIDTH (#1056)
* Replace magic numbers with TILE_WIDTH

* Address more instances
2023-07-26 19:50:16 -05:00
Idain
1d64befdb7
Replace magic number with TEXTBOX_FRAME_TILES (#1057) 2023-07-18 08:58:37 -05:00
mid-kid
cf1c505555 GetNicknamenamePointer -> GetNicknamePointer
Found this commit on an old drive
2023-02-26 12:28:06 +01:00
vulcandth
cb8505e022
Define InitDefaultEZChatMsgs and sEZChatMessages (#1022) 2022-12-26 13:55:01 -05:00
Rangi
4387298b2c Comment the Crystal 1.0 bugs as "BUG:" too 2022-12-14 22:30:20 -05:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
mid-kid
cff8aec3a7 mobile/mobile_45.asm -> lib/mobile/mail.asm
This file is part of the official mobile adapter SDK, although unlike
lib/mobile/main.asm, this file was included as source code the
developers could modify.
2022-09-08 12:55:14 +02:00
Rangi
4883950318 Use for loops to generate box pointer tables
Fixes #996
2022-08-31 18:03:49 -04:00
Rangi
07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth
66d84ff021
MobileCheckOwnMonAnywhere & CheckOwnMonAnywhere Label, comments, formatting (#927)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 23:21:08 -04:00
vulcandth
73c020074e
Remove redundant comments referencing labels (#921) 2022-06-06 17:34:54 -04:00
vulcandth
3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c
Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
vulcandth
d226ccab0a
Prune trailing whitespace (#913) 2022-05-06 13:09:51 -04:00
vulcandth
31c3c94d64
Build the Virtual Console patch with make crystal11_vc (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
3a562f9896 Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
mid-kid
1dc88cb585 Enumerate MobileAPI function constants 2022-01-23 18:13:41 +00:00
Idain
5ac4a51751
Use time constants more often (#867) 2022-01-10 20:57:40 -05:00
Rangi
e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi
ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi
ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi
316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi
0506e5b1b9 Assert the sBox1-14 tables have NUM_BOXES entries 2021-03-21 17:47:53 -04:00
Rangi
4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00