Commit Graph

534 Commits

Author SHA1 Message Date
SnorlaxMonster
7c3d2956cd
Consistently use Japanese control codes for Japanese strings (#1222) 2026-01-24 15:37:50 -05:00
Rangi
45ef09d2bc Format OddEggProbabilities more like pokered WildMonEncounterSlotChances 2026-01-17 18:32:22 -05:00
Rangi
f9ba82248e
Specify a max item length for list_start (#1210) 2025-12-15 15:16:41 -05:00
Rangi
713b829198 Simplify tmhm macro assertion error output
Some checks failed
CI / build (push) Has been cancelled
2025-12-01 14:15:24 -05:00
Rangi
73b019c68d Don't use list_start/assert_list_length for roammon maps,
since `li` is not involved
2025-12-01 14:15:21 -05:00
Rangi
a55bc33d67
Use features of RGBDS 1.0.0 (#1204)
Some checks are pending
CI / build (push) Waiting to run
- Use single-quoted character literals or `CHARVAL` when you need
  a character's numeric value; using strings as numbers is deprecated
- Use `?` to silence a node in warning/error location backtraces
- Use `===` and `!==` instead of `STRCMP`, and `++` instead of `STRCAT`
- Use `__SCOPE__` instead of checking for `..` and `.` separately
- Use `#string` instead of `"{string}"`
- All programs (rgbasm, rgblink, rgbfix, rgbgfx) support `-W` warnings
- `rgbgfx --colors dmg` is short for `rgbgfx --colors dmg=e4`
2025-11-12 15:43:54 -05:00
Rangi
86acbe5b55
Use dname macro to automatically pad names with "@" characters (#1198)
Some checks failed
CI / build (push) Has been cancelled
2025-08-17 09:48:05 -04:00
Rangi
4c540aa43b
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#1186) 2025-06-23 09:11:33 -04:00
Rangi
a15a2970a1
Use features new to RGBDS 0.9.2 (#1180)
Some checks failed
CI / build (push) Has been cancelled
2025-05-10 12:47:43 -04:00
Rangi42
098944485b Rename "city" treemon set to "none", since it has no encounters
Some checks failed
CI / build (push) Has been cancelled
2025-04-21 12:42:57 -04:00
Rangi
85ddf0e90a
Don't pass redundant label names to table_width and list_start (#1160) 2024-12-27 12:35:35 -05:00
Hannabart Pekopon
3f686e67da
Correct wrong and misleading comments about enemy trainer AI (#1149)
Some checks are pending
CI / build (push) Waiting to run
2024-12-26 08:59:18 -05:00
Jordan Moore
d323aa83dd Rename checkcurl to checkrollout
Some checks are pending
CI / build (push) Waiting to run
2024-12-25 12:17:14 +01:00
Rangi42
26e9de55d6 Fix indentation
Some checks failed
CI / build (push) Has been cancelled
2024-12-16 10:48:48 -05:00
Sylvie
644bd42fb0
Identify more bit flags (#1153)
Some checks failed
CI / build (push) Has been cancelled
2024-11-29 19:29:30 -05:00
metallicity
0abd8a7b38
Rename Bill's brother to Bill's older sister (#1132) 2024-10-17 17:03:29 -04:00
Sylvie
2265e53d24
Rename dt and dd to bigdt and bigdd (#1141)
Some checks are pending
CI / build (push) Waiting to run
This makes their big-endianness obvious and matches `bigdw`
2024-10-17 14:52:47 -04:00
Sylvie
e59624d1f5
Generate Unown sprite palette based on all front+back sprites (#1146) 2024-10-17 13:39:33 -04:00
Sylvie
5a53e297cf
Sort Pokemon and trainer sprite palettes, with Makefile-specified exceptions (#1137)
Some checks are pending
CI / build (push) Waiting to run
This avoids the need to define their order via indexed PNG palettes

It also avoids the need to use gb-asm-tools' palfix.py on custom sprites

Fixes #1136
2024-10-16 10:48:00 -04:00
Sylvie
017bffaef9
Put front and back pics on a single line (#1139) 2024-09-26 00:20:04 -04:00
Sylvie
fed587fc37
Refactor the Unown wall word data (#1131) 2024-07-24 10:56:46 -04:00
Rangi42
4f57e96f31 Consolidate the duplicate stat level data files 2024-06-12 13:13:58 -04:00
Sylvie
8819f7b117
Identify various "????"s (#1125) 2024-06-11 20:54:45 -04:00
xCrystal
e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal
bd6ceec193 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-07 13:36:05 +01:00
Rangi
dbf6044650
Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
vulcandth
30739842af Document Tackle is missing part of its hit animation
Co-Authored-By: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
2024-01-03 15:41:28 +01:00
SnorlaxMonster
a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
vulcandth
aba1f14044
Sync sprite and battle anim consts/labels (#1055)
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 13:09:28 -05:00
Tiddlywinks
b0ddb0758d 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:08:27 +02:00
SoupPotato
6180be355e
Labeled framesets and related constants (#1063)
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-08-21 19:09:23 -05:00
Rangi
0d899cbd3b
Define all unused type names with rept (#1071)
Fixes #1070
2023-08-16 10:22:35 -04:00
Rangi
f3b31087e3 Use MAP_CONNECTION_PADDING_WIDTH in MACRO connection
Fixes #1033
2023-08-15 19:54:16 -04:00
SatoMew
768b3bdec1
Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
vulcandth
31c55dc74d
Use BattleAnim_Dummy in data/moves/animations.asm (#1052) 2023-06-22 16:15:43 -04:00
vulcandth
438c48daad
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
mid-kid
cfd432f468 Minor battle tower fixes 2023-03-08 13:52:47 +01:00
vulcandth
25e12c9391
wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Rangi
8fc3b8e6e3 Dance Theatre -> Dance Theater
Fixes #1008
2022-09-23 22:06:52 -04:00
Idain
553a272e52
TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:01:39 -05:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" (#983)
Fixes #982
2022-08-10 21:24:56 -04:00
Rangi
367a104203 PP must be 40 or less 2022-08-10 21:20:53 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi
f159654054 spriteanimoam macro corresponds to battleanimoam 2022-07-04 01:11:42 -04:00
Rangi
a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims"
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth
5f0597e944
Rename SLP to SLP_MASK (#918)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth
3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
Rangi
ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00