Leahnaya/pokecrystal
1
0
Fork 0
mirror of https://github.com/pret/pokecrystal.git synced 2026-03-21 17:45:29 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,257 Commits 2 Branches 0 Tags 102 MiB
master
Commit Graph

731 Commits

Author SHA1 Message Date
Rangi
9b69c36897
Fix the GoldenrodUndergroundSwitchRoomEntrances door-switch macros (#1245)
Some checks failed
CI / build (push) Has been cancelled
Details
CI / build-macos (push) Has been cancelled
Details
2026-03-01 18:18:46 -05:00
mid-kid
002b4e84f2
Use separate constants for wChosenCableClubRoom (#1240)
Some checks failed
CI / build (push) Has been cancelled
Details
CI / build-macos (push) Has been cancelled
Details 
These numbers aren't related to the LINK_ values at all, it's just a
coincidence.

Changing these is an easy way for games to force incompatibility with
the original game.
 2026-02-08 13:47:30 -05:00
SnorlaxMonster
7c3d2956cd
Consistently use Japanese control codes for Japanese strings (#1222) 2026-01-24 15:37:50 -05:00
Rangi
a718a256f8 Verify that only one of each callback type exists per map
Some checks failed
CI / build (push) Has been cancelled
Details 
Fixes #1213
 2025-12-15 15:43:39 -05:00
Rangi42
468488e7a5 Identify JOYP_SGB_MLT_REQ constant
Some checks failed
CI / build (push) Has been cancelled
Details
2025-08-11 16:38:46 -04:00
Rangi42
fcd13b1298 Update hardware.inc to 5.3.0 and use its new constants 2025-08-11 16:01:32 -04:00
Rangi42
306d1497c1 Update hardware.inc to 5.2.0
Some checks failed
CI / build (push) Has been cancelled
Details
2025-07-22 11:57:50 -04:00
Rangi42
5abf8d01fb Update hardware.inc to 5.1.0 2025-06-30 12:47:36 -04:00
Rangi42
36fdf1a1fc Restore macros/legacy.asm, and address some feedback on hardware.inc
Some checks failed
CI / build (push) Has been cancelled
Details
2025-06-23 10:43:55 -04:00
Rangi
4c540aa43b
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#1186) 2025-06-23 09:11:33 -04:00
Brianum
b8d0c93213
Make town map limits more intuitive (#1185) 2025-06-07 13:51:32 -04:00
Rangi
efceed1338
Use offsets from ANIM_* constants for wBattleAfterAnim (formerly wNumHits) (#1184) 2025-05-31 15:07:56 -04:00
Rangi
b035d9fb89
Define constants for wBillsPCPokemonList entries (#1183) 2025-05-31 15:07:44 -04:00
Rangi
fd2af282b6
Add a CANNOT_MOVE constant (#1182) 2025-05-31 15:07:34 -04:00
Rangi
a15a2970a1
Use features new to RGBDS 0.9.2 (#1180)
Some checks failed
CI / build (push) Has been cancelled
Details
2025-05-10 12:47:43 -04:00
Rangi42
098944485b Rename "city" treemon set to "none", since it has no encounters
Some checks failed
CI / build (push) Has been cancelled
Details
2025-04-21 12:42:57 -04:00
Rangi42
b4fc71cba1 Verify the battle BG effect pointer table length
Some checks failed
CI / build (push) Has been cancelled
Details
2025-03-15 01:23:04 -04:00
Rangi42
467ee7ee72 Sync further with pokegold 2025-03-15 01:03:28 -04:00
Rangi42
94c36a4351 Verify the trade dialog pointer table length 2025-03-15 00:49:14 -04:00
Rangi42
1cc2216ef9 Verify the mart types pointer table length 2025-03-15 00:44:33 -04:00
Rangi42
62cf0ba615 Name the unused engine flags according to their bit constants 2025-03-14 23:28:32 -04:00
Rangi42
15ae47a61e Separate constants for name types and naming screen types
Some checks failed
CI / build (push) Has been cancelled
Details
2025-03-12 12:26:21 -04:00
Rangi
4d6c3e2975
Avoid using EQUS when EQU or MACRO will do (#1166)
Some checks failed
CI / build (push) Has been cancelled
Details
2025-02-27 13:07:12 -05:00
Rangi
15187f5d63
Identify CHANNEL_FIELD16 as CHANNEL_NOTE_DURATION_MODIFIER (#1162) 2024-12-27 12:54:25 -05:00
Rangi42
e1e7cbd838 Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F 2024-12-02 12:16:30 -05:00
Sylvie
644bd42fb0
Identify more bit flags (#1153)
Some checks failed
CI / build (push) Has been cancelled
Details
2024-11-29 19:29:30 -05:00
metallicity
0abd8a7b38
Rename Bill's brother to Bill's older sister (#1132) 2024-10-17 17:03:29 -04:00
Sylvie
fed587fc37
Refactor the Unown wall word data (#1131) 2024-07-24 10:56:46 -04:00
Rangi42
23183bb9bb Rename wram_constants.asm to ram_constants.asm 2024-05-22 21:07:37 -04:00
Rangi42
b81e339f33 Use constants for VBlank handlers 2024-05-22 21:02:55 -04:00
SnorlaxMonster
b9dce73573
Rename MON_ID to MON_OT_ID (#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2024-04-27 12:16:34 -05:00
vulcandth
b0b5ed2eb8
Fix/update sprite y-coord offscreen definitions (#1108) 2024-04-14 15:55:46 -05:00
xCrystal
e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal
f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal
cd28c44ff3 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
 2024-01-07 13:36:28 +01:00
xCrystal
bd6ceec193 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-07 13:36:05 +01:00
Rangi
dbf6044650
Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
SnorlaxMonster
a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
vulcandth
05083d6fd2 Move charmap.asm to constants/ 
Resolves #1090
 2023-11-17 21:59:32 -06:00
vulcandth
aba1f14044
Sync sprite and battle anim consts/labels (#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 13:09:28 -05:00
Tiddlywinks
b0ddb0758d 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:08:27 +02:00
SoupPotato
6180be355e
Labeled framesets and related constants (#1063) 
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-08-21 19:09:23 -05:00
Rangi
9c0ef02d4b Verify that there aren't too many OAM constants 
Fixes #1062
 2023-08-15 19:45:33 -04:00
vulcandth
e07a1e7773
Define relationship between map_object and object_events (#1054) 2023-08-14 09:19:25 -05:00
SatoMew
768b3bdec1
Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
SnorlaxMonster
c931b98a81
Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (#1058) 
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-07-26 19:51:34 -05:00
vulcandth
438c48daad
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
mid-kid
4c4fd7258c Define SERIAL_PATCH_PREAMBLE_LENGTH 2023-04-19 19:12:14 +02:00
mid-kid
08cfbbb1d9 Document link patch lists a little bit better 2023-04-19 19:12:14 +02:00
mid-kid
a6ac67dea2 IsMailEuropean → ParseMailLanguage (and give it constants) 2023-04-19 19:12:14 +02:00