mirror of
https://github.com/pret/pmd-sky.git
synced 2026-10-02 07:08:09 -05:00
ec25edd9dd
Third cleanup sweep; five more asm files and their includes removed: asm/overlay_29_023021F0.s UpdateIqSkillsWrapper asm/overlay_29_022EBC98.s SetActionUseMovePlayer asm/overlay_29_02349658.s ov29_02349658 asm/main_0205EBF0.s sub_0205EBF0 asm/overlay_29_022F52B0.s ov29_022F52B0 SetActionUseMovePlayer sets ACTION_USE_MOVE_PLAYER and then two action_parameters[].action_use_idx fields, using the enumerator and struct that already exist. sub_0205EBF0 indexes mission_deliver_list::unk18, the struct src/main_0205C73C.c already uses, rather than a fresh placeholder. NOT done, deliberately: src/overlay_29_022F0EDC.c still carries the provisional `extern s32 SetActionUseMovePlayer();`. Replacing it with an include of the real header, which declares the function void, breaks the ROM -- SetLeaderAction's match depends on the s32 form. The two declarations therefore still disagree. That is a real defect in one of the two, not a formality, and it is left alone rather than papered over; see the reasoning note. ov29_022F52B0 is a bare veneer with no argument setup, so its arity is not evidenced by anything and void(void) is a guess. Authored by Claude (Opus 5) under human direction. All five verified at score 0. Confirmed by a matching build: build/pmdsky.us/pmdsky.us.nds: OK. None carries a region conditional, so US alone is sufficient. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pokémon Mystery Dungeon: Explorers of Sky
This is a WIP disassembly of Pokémon Mystery Dungeon: Explorers of Sky. For instructions on how to set up the repository, please read INSTALL.md. For information on how to contribute changes, see CONTRIBUTING.md.
This repository builds the following ROMs:
- pmdsky.us.nds
sha1: 5fa96ca8d8dd6405d6cd2bad73ed68bc73a9d152 - pmdsky.eu.nds
sha1: c838a5adf1ed32d2da8454976e5b1a1aa189c139 - pmdsky.jp.nds
sha1: 7785138dd343b6f2d0f2c9cadc26b4aa927161d7
For contacts and other pret projects, see pret.github.io.