mirror of
https://github.com/pret/pmd-sky.git
synced 2026-09-29 05:41:47 -05:00
d9df74f0f6
Second cleanup batch. Eight files are now gone: asm/overlay_29_022E1618.s asm/main_0202B530.s asm/overlay_29_022DC65C.s asm/main_0205EC38.s asm/overlay_29_0232124C.s asm/main_02051788.s asm/main_02042B20.s asm/main_02065BD8.s main.lsf falls from 1175 objects to 1167. Twenty-two functions matched across eleven files, but only seventeen land. FixedPoint64ToInt, GetSpriteSize and RemoveItemFromKecleonShop1 did not match, and their files therefore cannot be emptied; landing their already-matched siblings would have converted two two-function files into two fresh single-function fragments, so those two are held back as well. This batch reduces the fragment count without creating any. Three declarations follow the tree rather than the scratch: ov29_0232119C takes struct entity * as its first parameter, ov29_023538B4 is already declared as a u8 array, and ov29_022DC2B8 and ov29_022DC33C are declared u8 * in their destination file. That last one is inconsistent with poly_text.h, which declares ov29_022DC2B8 as struct unk_ov29_022DC240_t *; the file already carried the same split for ov29_022DC240, so its local convention was followed rather than changing pre-existing code. Worth unifying separately. Authored by Claude (Opus 5) under human direction. Confirmed by a matching build: build/pmdsky.us/pmdsky.us.nds: OK. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pokémon Mystery Dungeon: Explorers of Sky
This is a WIP disassembly of Pokémon Mystery Dungeon: Explorers of Sky. For instructions on how to set up the repository, please read INSTALL.md. For information on how to contribute changes, see CONTRIBUTING.md.
This repository builds the following ROMs:
- pmdsky.us.nds
sha1: 5fa96ca8d8dd6405d6cd2bad73ed68bc73a9d152 - pmdsky.eu.nds
sha1: c838a5adf1ed32d2da8454976e5b1a1aa189c139 - pmdsky.jp.nds
sha1: 7785138dd343b6f2d0f2c9cadc26b4aa927161d7
For contacts and other pret projects, see pret.github.io.