mirror of
https://github.com/pret/pmd-sky.git
synced 2026-09-28 13:24:02 -05:00
901ba2aa8f
Fourth cleanup sweep; five more asm files and their includes removed: asm/overlay_29_0232B8E4.s DoMoveCalmMind asm/overlay_29_0232D22C.s DoMoveHammerArm asm/overlay_29_023495E8.s IsDestinationFloorWithFleeingOutlaw asm/overlay_29_023492D4.s IsLegendaryChallengeFloor asm/main_02030850.s CloseAdvancedTextBox2 The two mission predicates merged into files that already declared IsCurrentMissionType and IsCurrentMissionTypeExact with enum mission_type parameters, so they use those declarations and the MISSION_* enumerators rather than fresh externs with integer types. IsLegendaryChallengeFloor's floor check is a byte subtraction written `+ 0xFF`, the same encoding DoMoveGust needed. Both predicates only match written as a nested `if` that falls through to a single return; the early-return spellings score 610 and 405. CloseAdvancedTextBox2 uses the existing sub_0202836C, sub_0202812C, DeleteWindow and MemFree declarations; only sub_020288DC needed a provisional extern. Authored by Claude (Opus 5) under human direction. All five verified at score 0. Confirmed by a matching build: build/pmdsky.us/pmdsky.us.nds: OK. None carries a region conditional, so US alone is sufficient. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pokémon Mystery Dungeon: Explorers of Sky
This is a WIP disassembly of Pokémon Mystery Dungeon: Explorers of Sky. For instructions on how to set up the repository, please read INSTALL.md. For information on how to contribute changes, see CONTRIBUTING.md.
This repository builds the following ROMs:
- pmdsky.us.nds
sha1: 5fa96ca8d8dd6405d6cd2bad73ed68bc73a9d152 - pmdsky.eu.nds
sha1: c838a5adf1ed32d2da8454976e5b1a1aa189c139 - pmdsky.jp.nds
sha1: 7785138dd343b6f2d0f2c9cadc26b4aa927161d7
For contacts and other pret projects, see pret.github.io.