mirror of
https://github.com/pret/pmd-sky.git
synced 2026-09-29 05:41:47 -05:00
883be16336
Two region-conditional calls the US build cannot see: - SetDecoyAiTracker(GetLeader()) is US/EU only. Its declaration in overlay_29_022FB538.h already sits inside #ifndef JAPAN, so calling it unconditionally broke the JP build at compile time, not just at the checksum. - ov29_022F2FE4() is an extra call EU makes after ov29_022E0B44() in the tail block, from an #ifdef EUROPE in the asm that the previous commit missed. The remaining region differences in the replaced asm need no source change. Two are struct-layout consequences that dungeon.h already models. The other three looked like swapped constants but are immediate encodability: in each region the value that is a single-instruction ARM immediate is materialized inline and the other is derived from the pooled 0xBA3 and cached in a stack slot. 0xBA0 and 0x8E0 encode; 0xBA1 and 0x8DF do not, and the JP offset of -0x2C1 swaps which of the pair is which. This corrects the previous commit, which stated that JP was expected not to match and that EU was unaffected. EU was in fact broken by it, and JP needed one guarded call rather than a rewrite. Authored by Claude (Opus 5) under human direction. Confirmed by matching builds of all three targets: build/pmdsky.us/pmdsky.us.nds: OK, build/pmdsky.eu/pmdsky.eu.nds: OK, build/pmdsky.jp/pmdsky.jp.nds: OK. EU and JP were verified matching at the parent commit as well, so both are gains rather than a pre-existing state. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pokémon Mystery Dungeon: Explorers of Sky
This is a WIP disassembly of Pokémon Mystery Dungeon: Explorers of Sky. For instructions on how to set up the repository, please read INSTALL.md. For information on how to contribute changes, see CONTRIBUTING.md.
This repository builds the following ROMs:
- pmdsky.us.nds
sha1: 5fa96ca8d8dd6405d6cd2bad73ed68bc73a9d152 - pmdsky.eu.nds
sha1: c838a5adf1ed32d2da8454976e5b1a1aa189c139 - pmdsky.jp.nds
sha1: 7785138dd343b6f2d0f2c9cadc26b4aa927161d7
For contacts and other pret projects, see pret.github.io.