mirror of
https://github.com/pret/pmd-sky.git
synced 2026-09-28 05:07:58 -05:00
7e1755ddf8
Each function was verified at score 0 against its NORTH_AMERICA, EUROPE and
JAPAN targets before landing, with the address walk closing exactly in each
region, and by a matching US build after.
main_020517D4.c GetRankUpEntry
main_02001188.c MemAlloc
main_0203088C.c CloseAdvancedTextBox
main_020114F8.c ApplyGummiBoostsToGroundMonster
main_0205283C.c GetExp
overlay_29_02305C04.c EndNegativeStatusConditionWrapper
overlay_29_02338350.c NearbyAllyIqSkillIsEnabled
overlay_29_022E9FC0.c AdvanceFrame
overlay_29_022E99F0.c TickStatusTurnCounter
overlay_29_0234B4BC.c LogMessageByIdWithPopup
overlay_29_0234B340.c LogMessageByIdWithPopupCheckUserTarget
All eleven sat at the head or tail of their .s, so every one merges into the
adjacent source file and no assembly file is split.
Forty call-site declarations of these functions are replaced by an include of
the owning header. Two of them disagreed with the real signature, and one had to
be fixed for the tree to compile at all:
MemAlloc was declared six different ways. src/overlay_24_end.c spelled it
`void* MemAlloc(s32, s32);` -- signed -- and that file already
includes main_02001188.h, so the contradiction became a hard
compile error the moment MemAlloc had a header to contradict.
It had been harmless only because the function had none.
AdvanceFrame was declared `void AdvanceFrame(u8);` in two overlay_31 files
against the real u32. Byte-neutral in practice, since every call
site passes the literal 0x62, but wrong.
struct unk_020517F4 was defined file-locally in src/main_0203D538.c. It now has
one definition, in include/main_020517D4.h, and both local copies are gone --
otherwise including that header where GetRankUpEntry is called would collide.
Two generated headers are made self-contained. extract_function.py emits a
header that names types it does not include, and since the .c includes it first,
the prototype builds its own scoped tag: include/main_020114F8.h declaring
`struct ground_monster *` before common.h defines it made the definition read as
a redeclaration with a different type.
Authored by Claude (Opus 5) under human direction. Confirmed by a matching
build: build/pmdsky.us/pmdsky.us.nds: OK.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pokémon Mystery Dungeon: Explorers of Sky
This is a WIP disassembly of Pokémon Mystery Dungeon: Explorers of Sky. For instructions on how to set up the repository, please read INSTALL.md. For information on how to contribute changes, see CONTRIBUTING.md.
This repository builds the following ROMs:
- pmdsky.us.nds
sha1: 5fa96ca8d8dd6405d6cd2bad73ed68bc73a9d152 - pmdsky.eu.nds
sha1: c838a5adf1ed32d2da8454976e5b1a1aa189c139 - pmdsky.jp.nds
sha1: 7785138dd343b6f2d0f2c9cadc26b4aa927161d7
For contacts and other pret projects, see pret.github.io.