mirror of
https://github.com/pret/pmd-sky.git
synced 2026-09-28 13:24:02 -05:00
78b52f9d63
Fifth cleanup sweep; five more asm files and their includes removed: asm/overlay_29_023491C4.s IsOutlawOrChallengeRequestFloor asm/main_0202AAE8.s sub_0202AAE8 asm/main_0202BC60.s sub_0202BC60 asm/overlay_29_023261A0.s DoMoveBubble asm/main_0205BCC4.s sub_0205BCC4 sub_0202AAE8 and sub_0202BC60 are the same function over different window states: check unk_0202AAA8::field_0x19C against a set, then set two flags, clear field_0x1A4, call sub_0202830C with -5 and advance the state. Both write a byte at 0x1A1 that the struct covered only as padding after field_0x1A0, so that gap is now named field_0x1A1 with field_0x1A2[2] holding the remainder -- same total size. Three spellings that mattered: - IsOutlawOrChallengeRequestFloor is three ORed predicates and only matches with each operand written `!= 0`; a plain || scores 300 and early returns 1300. - DoMoveBubble returns whether damage was dealt, not whether the speed drop landed, so the result is funnelled through one variable which is also passed as LowerSpeed's stage count. - sub_0205BCC4 must not hoist the destination pointer above its NULL check; a local shared by both branches scores 830, one declared inside the else branch matches. Authored by Claude (Opus 5) under human direction. All five verified at score 0. Confirmed by a matching build: build/pmdsky.us/pmdsky.us.nds: OK. None carries a region conditional, so US alone is sufficient. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pokémon Mystery Dungeon: Explorers of Sky
This is a WIP disassembly of Pokémon Mystery Dungeon: Explorers of Sky. For instructions on how to set up the repository, please read INSTALL.md. For information on how to contribute changes, see CONTRIBUTING.md.
This repository builds the following ROMs:
- pmdsky.us.nds
sha1: 5fa96ca8d8dd6405d6cd2bad73ed68bc73a9d152 - pmdsky.eu.nds
sha1: c838a5adf1ed32d2da8454976e5b1a1aa189c139 - pmdsky.jp.nds
sha1: 7785138dd343b6f2d0f2c9cadc26b4aa927161d7
For contacts and other pret projects, see pret.github.io.