Commit Graph

1384 Commits

Author SHA1 Message Date
CecilArmitais
6e975da39b
Added comments to script_entity_id 2026-07-24 13:35:26 -07:00
cecilarmitais
c72c378044 Decomp special-actor setters; identify SPECIAL_ACTORS (_020B0B08)
Decompile eight ground-mode setters from asm into src/main_02065B3C.c:
SetActorTalkMainAndActorTalkSub, SetActorTalkMain, SetActorTalkSub,
SetActorEventMain, SetRandomRequestNpcs1And2, SetRandomRequestNpc03KindVar,
SetAllEventNpcs and SetNewFriendActor.

Identify the global they write, _020B0B08, as a 28-byte table of slots keyed by
the special members of enum script_entity_id (ENTITY_TALK_MAIN 46 through
ENTITY_NPC_DEMO_PARTNER 59). Every slot offset is corroborated by both a writer
above and the reader that resolves it at the matching entity id: sub_0206549C,
reached via GetScriptEntityMonsterId, and sub_02065050, reached via
GetActorMatchingStorageId. Name the type struct special_actors and relabel the
symbol _020B0B08 -> SPECIAL_ACTORS at its definition in
asm/main_rodata_020A2808.s and at every reference.

Extracting the block splits asm/main_0205EDA4.s: the trailing functions move
verbatim into asm/main_02065BD8.s, the affected .inc files are regenerated, and
main.lsf gains the two new objects.

Add enum script_entity_id to include/enums.h, taken from pmdsky-debug, since
struct special_actors refers to it.

No comments are added to any pmd-sky file; comments cannot be checked by the
matching build, so the code is left to stand on its own.

Authored by Claude (Opus 4.8) under human direction. Confirmed by a matching
build: build/pmdsky.us/pmdsky.us.nds: OK.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-21 00:39:51 -07:00
AnonymousRandomPerson
ca0fb7116a
Merge pull request #282 from CecilArmitais/decomp-IsSkyExclusiveDungeon
Some checks failed
build / build (push) Has been cancelled
IsSkyExclusiveDungeon (Claude Matched, Human Confirmed)
2026-07-20 17:53:07 -04:00
cecilarmitais
3a80e75ed3 Decomp IsSkyExclusiveDungeon
Authored by Claude (Opus 4.8) under human direction. Confirmed by a matching
build: build/pmdsky.us/pmdsky.us.nds: OK.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-19 16:27:08 -07:00
AnonymousRandomPerson
014967fda3
Merge pull request #281 from AnonymousRandomPerson/main
Some checks failed
build / build (push) Has been cancelled
Synced from pmdsky-debug
2026-07-16 00:18:02 -04:00
AnonymousRandomPerson
5431619314 Synced from pmdsky-debug 2026-07-15 22:50:47 -04:00
AnonymousRandomPerson
a7873e861b Synced from pmdsky-debug 2026-07-15 22:12:22 -04:00
AnonymousRandomPerson
b1f1a46577
Merge pull request #280 from Zur3l/main
Some checks failed
build / build (push) Has been cancelled
Decomp 37 functions
2026-07-11 23:52:39 -04:00
Zur3l
00953d57af Decomp IsCastform and IsCherrim
Both decomped by @Chesyon and @taxicat1, thanks
2026-07-11 17:55:51 -04:00
Zur3l
4c368ab4e1 Add some decomp.me links 2026-07-11 17:18:26 -04:00
Zur3l
999df284ff Decomp BaseFormsEqual 2026-07-11 17:18:26 -04:00
Zur3l
c49eb69081 Decomp GetMoveCategory 2026-07-11 17:18:26 -04:00
Zur3l
9a03d2ac98 Decomp IsSameMove 2026-07-11 17:18:26 -04:00
Zur3l
356f786127 Decomp IsRealMoveInTimeDarkness, IsMovesetValidInTimeDarkness, and GetFirstNotRealMoveInTimeDarkness 2026-07-11 17:18:26 -04:00
Zur3l
5b17f3f97f Decomp IsMovesetValid
Thanks @taxicat1
2026-07-11 17:18:26 -04:00
Zur3l
fcca1fecac Decomp IsRealMove 2026-07-11 17:18:26 -04:00
Zur3l
5d30f28cd6 Decomp IsNot2TurnsMoveOrSketch 2026-07-11 17:18:26 -04:00
Zur3l
a5c869f004 Decomp IsOneHitKoMove 2026-07-11 17:18:26 -04:00
Zur3l
7bfd15116c Decomp IsTrappingMove 2026-07-11 17:18:26 -04:00
Zur3l
e8ce1c84e1 Decomp IsCopyingMove 2026-07-11 17:18:26 -04:00
Zur3l
7245b85a8c Decomp IsHealingWishOrLunarDance 2026-07-11 17:18:26 -04:00
Zur3l
7bd5b913cd Decomp IsPunchMove
Decomped by @SethBarberee and @taxicat1, thanks
2026-07-11 17:18:26 -04:00
Zur3l
8ad94ec216 Decomp ReturnEggExclusiveItem 2026-07-11 17:18:26 -04:00
Zur3l
38704de35e Decomp GetMoneyQuantity 2026-07-11 17:18:26 -04:00
Zur3l
5a60a98ad9 Decomp sub_0200D894 2026-07-11 17:18:26 -04:00
Zur3l
a929271ae0 Decomp AreItemsEquivalent 2026-07-11 17:18:26 -04:00
Zur3l
539dd92880 Decomp ItemZInit 2026-07-11 17:18:26 -04:00
Zur3l
e02ba958fb Decomp GetActualSellPrice 2026-07-11 17:18:25 -04:00
Zur3l
2ea04fcaf7 Decomp GetActualBuyPrice 2026-07-11 17:18:25 -04:00
Zur3l
59b2967ed6 Decomp GetDisplayedSellPrice 2026-07-11 17:18:25 -04:00
Zur3l
f68ebbebed Decomp GetDisplayedBuyPrice 2026-07-11 17:18:25 -04:00
Zur3l
05563134ab Decomp ItemToBulkItem
Thanks @SethBarberee
2026-07-11 17:18:25 -04:00
Zur3l
d03db2f6c7 Move GET_BIT to util.h and rename to GET_FLAG 2026-07-11 17:18:25 -04:00
Zur3l
530d75f1e6 Decomp BulkItemToItem
Thanks @SethBarberee
2026-07-11 17:18:25 -04:00
Zur3l
7e5c2720b8 Decomp GetRngSeed 2026-07-11 17:18:25 -04:00
Zur3l
5534d0f55d Decomp SetRngSeed 2026-07-11 17:18:25 -04:00
Zur3l
40b37d1530 Decomp FixedPoint64IsNegative 2026-07-11 17:18:25 -04:00
Zur3l
ed1120ad38 Decomp FixedPoint64IsZero 2026-07-11 17:18:25 -04:00
Zur3l
5465cb5f04 Decomp NegateFixedPoint64 2026-07-11 17:18:25 -04:00
Zur3l
5744dcead0 Decomp FixedPoint32To64
Thanks @taxicat1
2026-07-11 17:18:25 -04:00
Zur3l
15bc9a91ae Decomp IntToFixedPoint64 2026-07-11 17:18:25 -04:00
Zur3l
7e53278b53 Decomp sub_02001BB4
Thanks @taxicat1
2026-07-11 17:18:25 -04:00
Zur3l
6a4d1cbcc7 Decomp sub_02001AB0 2026-07-11 17:18:25 -04:00
Zur3l
0c25e25955 Decomp MultiplyByFixedPoint 2026-07-11 17:18:25 -04:00
AnonymousRandomPerson
b927837596
Merge pull request #279 from Chesyon/main
Some checks are pending
build / build (push) Waiting to run
Decomp GetPartnerOptionString and PersonalityTestDebug
2026-07-10 17:55:17 -04:00
Chesyon
847fc35bf2 Decomp PersonalityTestDebug 2026-07-11 00:26:53 +03:00
Chesyon
6329817b62 merge 238BE4C into 238BDA8 2026-07-10 23:25:29 +03:00
Chesyon
5db0d433e0 Decomped GetPartnerOptionString
overhauled the personality_test struct (formerly Overlay13Main) to match pmdsky-debug
overhauled preprocessor_args to match pmdsky-debug
renamed some variables in GetPersonality to better document its functionality
2026-07-10 23:22:20 +03:00
AnonymousRandomPerson
0199797926
Merge pull request #278 from AnonymousRandomPerson/main
Some checks failed
build / build (push) Has been cancelled
Synced from pmdsky-debug
2026-07-07 21:01:19 -04:00
AnonymousRandomPerson
281367aae1 Synced from pmdsky-debug 2026-07-07 20:46:43 -04:00