Clean common strings and personality test 1

include/common_strings.h

@@ -33,6 +33,6 @@ extern const u8* const gCommonKecleonBros[KECLEON_BROS_MODE_COUNT][KECLEON_DLG_M
 extern const u8* const gCommonWigglytuff[WIGGLYTUFF_SHOP_MODE_COUNT][WIGGLY_DLG_MAX];
 extern const u8* const gCommonGulpin[GULPIN_SHOP_MODE_DIALOGUE_COUNT][GULPIN_DLG_MAX];
 extern const u8* const gCommonMakuhita[MAKUHITA_DOJO_MODE_COUNT][MAKUHITA_DLG_MAX];
-extern const Hints gCommonHints[NUM_HINTS];
+extern const Hints gCommonHints[HINT_MAX];
 
 #endif // GUARD_COMMON_STRINGS_H

include/constants/common_strings_hints.h

@@ -8,6 +8,14 @@ typedef struct Hints
     const u8 *body;
 } Hints;
 
-#define NUM_HINTS 5
+enum HintKind
+{
+    HINT_TOWN_CONTROLS_1,
+    HINT_TOWN_CONTROLS_2,
+    HINT_SAVING,
+    HINT_ADVENTURES_WITH_FRIENDS,
+    HINT_BUILDING_A_TEAM,
+    HINT_MAX
+};
 
 #endif // GUARD_COMMON_STRINGS_HINTS_H

include/constants/common_strings_kangaskhan_storage.h

@@ -24,9 +24,9 @@ enum KangaskhanStorageDialogue
     KANG_DLG_WITHDRAW_CONFIRMATION,
     KANG_DLG_YOU_HAVE_NOTHING,
     KANG_DLG_YOU_ARE_FULL,
-    KANG_DLG_STORAGE_HAS_NOTHING,
-    KANG_DLG_DEPOSIT__INVALID_ITEM,
-    KANG_DLG_DEPOSIT__TOO_MANY_OF_ITEM,
+    KANG_DLG_STORAGE_EMPTY,
+    KANG_DLG_DEPOSIT_INVALID_ITEM,
+    KANG_DLG_DEPOSIT_TOO_MANY_OF_ITEM,
     KANG_DLG_STORAGE_FULL,
     KANG_DLG_HOW_IT_WORKS,
     KANG_DLG_MAX

include/constants/personality_test.h

@@ -17,15 +17,14 @@ enum NaturePersonalities
     LONELY,
     QUIRKY,
     MISC,
-
 };
 
 #define NUM_PARTNERS 10
 #define NUM_QUIZ_QUESTIONS 55
 #define MAX_ASKED_QUESTIONS 8
 #define NUM_PERSONALITIES MISC
-#define NUM_PERSONALITY_TEST_EFFECTS (NUM_PERSONALITIES+3)
+#define NUM_PERSONALITY_TEST_EFFECTS (NUM_PERSONALITIES + 3)
 
 #define BRAVE_2B_TRIGGER 99
 
-#endif // GUARD_CONSTANTS_PERSONALITY_TEST_H
+#endif // GUARD_CONSTANTS_PERSONALITY_TEST_H