Leahnaya/mastodon
1
0
Fork 0
mirror of https://github.com/mastodon/mastodon.git synced 2026-09-12 15:35:46 -05:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Convert admin/disputes/appeals controller to system spec (#40124)

Browse Source
This commit is contained in:
Matt Jankowski
2026-08-17 12:11:50 +00:00
committed by GitHub
parent 0a005ddcd5
commit d0992cc096
2 changed files with 68 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
spec/controllers/admin/disputes/appeals_controller_spec.rb
View File

@@ -1,79 +0,0 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Admin::Disputes::AppealsController do
render_views
before do
sign_in current_user, scope: :user
target_account.suspend!
end
let(:target_account) { Fabricate(:account) }
let(:strike) { Fabricate(:account_warning, target_account: target_account, action: :suspend) }
let(:appeal) { Fabricate(:appeal, strike: strike, account: target_account) }
describe 'GET #index' do
let(:current_user) { Fabricate(:admin_user) }
before { appeal }
it 'returns a page that lists details of appeals' do
get :index
expect(response)
.to have_http_status(:success)
expect(response.parsed_body)
.to have_css('span.username', text: strike.account.username)
.and have_css('span.target', text: appeal.account.username)
end
end
describe 'POST #approve' do
subject { post :approve, params: { id: appeal.id } }
let(:current_user) { Fabricate(:admin_user) }
it 'redirects back to the strike page and notifies target account about approved appeal', :inline_jobs do
emails = capture_emails { subject }
expect(response)
.to redirect_to(admin_disputes_strike_path(appeal.strike))
expect(target_account.reload)
.to_not be_suspended
expect(emails.size)
.to eq(1)
expect(emails.first)
.to have_attributes(
to: contain_exactly(target_account.user.email),
subject: eq(I18n.t('user_mailer.appeal_approved.subject', date: I18n.l(appeal.created_at)))
)
end
end
describe 'POST #reject' do
subject { post :reject, params: { id: appeal.id } }
let(:current_user) { Fabricate(:admin_user) }
it 'redirects back to the strike page and notifies target account about rejected appeal', :inline_jobs do
emails = capture_emails { subject }
expect(response)
.to redirect_to(admin_disputes_strike_path(appeal.strike))
expect(emails.size)
.to eq(1)
expect(emails.first)
.to have_attributes(
to: contain_exactly(target_account.user.email),
subject: eq(I18n.t('user_mailer.appeal_rejected.subject', date: I18n.l(appeal.created_at)))
)
end
end
end

68
spec/system/admin/disputes/appeals_spec.rb Normal file
View File

@@ -0,0 +1,68 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe 'Admin Disputes Appeals' do
before do
sign_in(user)
target_account.suspend!
end
let(:user) { Fabricate(:admin_user) }
let(:target_account) { Fabricate(:account) }
let(:strike) { Fabricate(:account_warning, target_account: target_account, action: :suspend) }
let!(:appeal) { Fabricate(:appeal, strike: strike, account: target_account) }
describe 'Viewing the disputed appeals list' do
it 'returns a page that lists details of appeals' do
visit admin_disputes_appeals_path
expect(page)
.to have_css('span.username', text: strike.account.username)
.and have_css('span.target', text: appeal.account.username)
end
end
describe 'Approving an appeal' do
it 'redirects back to the strike page and notifies target account about approved appeal', :inline_jobs do
visit admin_disputes_strike_path(strike)
expect { click_on I18n.t('disputes.strikes.approve_appeal') }
.to send_email(to: target_account.user.email, subject: approve_subject)
expect(page)
.to have_title(strike_title)
expect(target_account.reload)
.to_not be_suspended
end
def approve_subject
I18n.t('user_mailer.appeal_approved.subject', date: I18n.l(appeal.created_at))
end
end
describe 'Rejecting an appeal' do
it 'redirects back to the strike page and notifies target account about rejected appeal', :inline_jobs do
visit admin_disputes_strike_path(strike)
expect { click_on I18n.t('disputes.strikes.reject_appeal') }
.to send_email(to: target_account.user.email, subject: reject_subject)
expect(page)
.to have_title(strike_title)
expect(target_account.reload)
.to be_suspended
end
def reject_subject
I18n.t('user_mailer.appeal_rejected.subject', date: I18n.l(appeal.created_at))
end
end
def strike_title
I18n.t('disputes.strikes.title', action: I18n.t(strike.action, scope: 'disputes.strikes.title_actions'), date: I18n.l(strike.created_at.to_date))
end
end