Fix serialization when an account is missing (#38370)
Some checks are pending
Check i18n / check-i18n (push) Waiting to run
Chromatic / Check for relevant changes (push) Waiting to run
Chromatic / Run Chromatic (push) Blocked by required conditions
CodeQL / Analyze (actions) (push) Waiting to run
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (ruby) (push) Waiting to run
Check formatting / lint (push) Waiting to run
Ruby Linting / lint (push) Waiting to run
Historical data migration test / test (14-alpine) (push) Waiting to run
Historical data migration test / test (15-alpine) (push) Waiting to run
Historical data migration test / test (16-alpine) (push) Waiting to run
Historical data migration test / test (17-alpine) (push) Waiting to run
Ruby Testing / build (production) (push) Waiting to run
Ruby Testing / build (test) (push) Waiting to run
Ruby Testing / test (.ruby-version) (push) Blocked by required conditions
Ruby Testing / test (3.2) (push) Blocked by required conditions
Ruby Testing / test (3.3) (push) Blocked by required conditions
Ruby Testing / End to End testing (.ruby-version) (push) Blocked by required conditions
Ruby Testing / End to End testing (3.2) (push) Blocked by required conditions
Ruby Testing / End to End testing (3.3) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (.ruby-version, docker.elastic.co/elasticsearch/elasticsearch:7.17.29) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (.ruby-version, docker.elastic.co/elasticsearch/elasticsearch:8.19.2) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (.ruby-version, opensearchproject/opensearch:2) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (3.2, docker.elastic.co/elasticsearch/elasticsearch:7.17.29) (push) Blocked by required conditions
Ruby Testing / Elastic Search integration testing (3.3, docker.elastic.co/elasticsearch/elasticsearch:7.17.29) (push) Blocked by required conditions

This commit is contained in:
David Roetzel
2026-03-24 17:42:57 +01:00
committed by GitHub
parent c72ca33fac
commit a3bdcc71e7
2 changed files with 17 additions and 4 deletions

View File

@@ -10,6 +10,6 @@ class REST::CollectionWithAccountsSerializer < ActiveModel::Serializer
end
def accounts
[object.account] + object.collection_items.map(&:account)
[object.account] + object.collection_items.filter_map(&:account)
end
end

View File

@@ -26,11 +26,14 @@ RSpec.describe REST::CollectionWithAccountsSerializer do
discoverable: false,
tag:)
end
before do
accounts[1..2].each do |account|
let(:collection_items) do
accounts[1..2].map do |account|
Fabricate(:collection_item, collection:, account:)
end
end
before do
collection_items
collection.reload
end
@@ -56,4 +59,14 @@ RSpec.describe REST::CollectionWithAccountsSerializer do
)
expect(subject['accounts'].size).to eq 3
end
context 'when collection includes pending items without account' do
let(:collection_items) do
[Fabricate(:collection_item, collection:, account: nil, object_uri: 'https://example.com/actor/1', state: :pending)]
end
it 'renders successfully' do
expect(subject).to be_a Hash
end
end
end