Fix WebUI fetching deleted quote in an endless loop (#35909)

2026-04-24 23:29:30 -05:00 · 2025-08-26 12:07:02 +02:00 · 2025-08-26 12:07:02 +02:00 · 3c9bde31f7
commit 3c9bde31f7
parent a8166d28ed
1 changed files with 3 additions and 2 deletions
--- a/app/javascript/mastodon/components/status_quoted.tsx
+++ b/app/javascript/mastodon/components/status_quoted.tsx
@ -84,12 +84,13 @@ export const QuotedStatus: React.FC<QuotedStatusProps> = ({
  const status = useAppSelector((state) =>
    quotedStatusId ? state.statuses.get(quotedStatusId) : undefined,
  );
+  const isQuoteLoaded = !!status && !status.get('isLoading');

  useEffect(() => {
-    if (!status && quotedStatusId) {
+    if (!isQuoteLoaded && quotedStatusId) {
      dispatch(fetchStatus(quotedStatusId));
    }
-  }, [status, quotedStatusId, dispatch]);
+  }, [isQuoteLoaded, quotedStatusId, dispatch]);

  // In order to find out whether the quoted post should be completely hidden
  // due to a matching filter, we run it through the selector used by `status_container`.