Commit Graph

46001 Commits

Author SHA1 Message Date
Andy1210
21ace56160 VideoBackends/OGL: Don't call glMemoryBarrier without ARB_shader_image_load_store
glMemoryBarrier comes from ARB_shader_image_load_store, so on a desktop context
below GL 4.2 the pointer is null. bSupportsBBox is set from
bSupportsFragmentStoresAndAtomics, which such a driver can still have, so saving
a state reads the bounding box and calls a null pointer.

UsePersistentStagingBuffers() in OGLTexture.cpp already guards the same call with
bSupportsImageLoadStore.
2026-08-07 17:09:46 +02:00
Scott Mansell
430138f468 Merge pull request #14798 from sepalani/bitcast-noptr
Common/BitCastPtr: Prevent destination type to be a pointer
2026-08-07 14:55:50 +12:00
Sepalani
6496d6c0c9 Common/BitCastPtr: Prevent destination type to be a pointer 2026-08-05 00:15:16 +04:00
Admiral H. Curtiss
66d8a89220 Merge pull request #14788 from phire/mach_msg_alignment
Mach exception thread: Fix msg alignment
2026-08-03 16:04:47 +02:00
Scott Mansell
9c5ff6b248 Mach exception thread: Fix msg alignment
msg_in and msg_out were ending up with only 4-byte alignment, which
is undefined behaviour, since they contain 64-bit fields. Probably
doesn't cause any issues, but it showed up in ubsan.
2026-08-03 22:46:45 +12:00
Admiral H. Curtiss
4af65cbed0 Merge pull request #14785 from JosJuice/fix-texture-count
VideoCommon: Fix custom texture count in OSD message
2026-08-02 14:19:09 +02:00
JosJuice
f5be1c30e5 VideoCommon: Fix custom texture count in OSD message
83dc468 broke the OSD message that shows the number of custom textures.
If Prefetch Custom Textures was disabled, the number would always be 0.
2026-08-02 10:11:15 +02:00
Scott Mansell
35925ceb15 Merge pull request #14777 from tygyh/Use-designated-constructors
Use designated constructors
2026-08-02 15:59:42 +12:00
Dr. Dystopia
be3ad38ec7 Use designated constructors 2026-08-01 21:37:43 +02:00
Scott Mansell
5c6dcce721 Merge pull request #14758 from JoshuaVandaele/egl-platform-nowayland
Forbid EGL_PLATFORM to be "wayland"
2026-08-02 02:57:00 +12:00
JosJuice
ad7e793548 Merge pull request #14768 from phire/security/gcz_overflows
Better validation and handling of GCZ
2026-08-01 12:26:10 +02:00
Scott Mansell
3c63788e01 Merge pull request #14776 from tygyh/Core/Use-static-cast
Replace functional cast with `static_cast`
2026-08-01 22:17:15 +12:00
Scott Mansell
463bcb8aeb Merge pull request #14781 from sepalani/gai-error
IP/Top: Add getaddrinfo() error log message
2026-08-01 22:15:10 +12:00
Sepalani
a3a43f9bd2 IP/Top: Add getaddrinfo() error log message 2026-07-31 18:25:54 +04:00
Joshua Vandaële
1c2b7fbf7f EGLX11: Forbid EGL_PLATFORM to be "wayland" 2026-07-31 10:34:00 +02:00
Scott Mansell
f1b4345d08 Merge pull request #14755 from JoshuaVandaele/cmakeupd-qt-useless-dlls
windeployqt: Disable uneeded DLLs
2026-07-31 18:00:43 +12:00
Scott Mansell
3bd410c4c5 Merge pull request #14775 from tygyh/Replace-zero-constants-with-nullptr
Replace zero constants with `nullptr`
2026-07-31 13:49:48 +12:00
OatmealDome
e463c64b7a Merge pull request #14779 from phire/cmake_osx_sysroot
Make sure CMAKE_OSX_SYSROOT is set
2026-07-30 19:54:12 -04:00
Scott Mansell
74c51895c8 Merge pull request #13452 from tygyh/Use-structured-binding-DolphinQt-FifoAnalyzer
DolphinQt/FIFO/FifoAnalyzer: Use structured bindings
2026-07-31 01:02:32 +12:00
Scott Mansell
5e1e4dbc4c Merge pull request #14778 from JoshuaVandaele/about-enable-sdl
AboutDialog: Fix compilation with ENABLE_SDL=OFF
2026-07-31 00:57:12 +12:00
Dr. Dystopia
a5552e612c Replace functional cast with static_cast 2026-07-30 14:18:47 +02:00
Scott Mansell
dbbe5c403e Make sure CMAKE_OSX_SYSROOT is set
Otherwise we can get some really weird build issues
2026-07-30 23:36:01 +12:00
Scott Mansell
20fea85b53 Merge pull request #14765 from slick-daddy/opt-6
InputCommon: return the device list directly in GetAllDevices
2026-07-30 21:10:41 +12:00
JosJuice
8b8d0847ae Merge pull request #14725 from matheuswillder/NFS-Codes-update
GameINI: Update codes to unlock Black Edition and Collector's Edition in Need for Speed (update to #14581)
2026-07-29 22:49:32 +02:00
Joshua Vandaële
d5e3c2bcfc AboutDialog: Fix compilation with ENABLE_SDL=OFF 2026-07-29 21:27:06 +02:00
Dr. Dystopia
61e97c9a09 Replace zero constants with nullptr 2026-07-29 18:15:38 +02:00
Scott Mansell
73de7b8d3e Merge pull request #13502 from tygyh/Replace-lazy-implementation-Tools-find-includes-cycles
Tools/find-includes-cycles: Replace lazy implementation
2026-07-29 18:25:39 +12:00
Scott Mansell
e9317dbe48 Merge pull request #14115 from techflashYT/elf-loader-fix
Core/Boot: Fix ELF load address semantics
2026-07-29 18:12:24 +12:00
Scott Mansell
a7345f8bde Merge pull request #14753 from matellush/flatpak-libevdev
Flatpak: Bump `libevdev` to the latest version
2026-07-29 17:52:35 +12:00
Scott Mansell
c863abc0d3 Merge pull request #14770 from JoshuaVandaele/gen-approved-hash
AchievementApprovedHash: Automatically generate hash using CMake
2026-07-29 17:49:48 +12:00
Scott Mansell
9b726fd56b Merge pull request #13543 from tygyh/DiscIO-Use-views-keys
DiscIO: Use views::keys
2026-07-29 17:49:24 +12:00
Scott Mansell
a3a5834100 Merge pull request #14766 from phire/security/dol_reader
DolReader: Fix integer wraparound
2026-07-29 13:30:04 +12:00
Scott Mansell
1c10b9e9ab Merge pull request #14738 from tygyh/Replace-concatination-with-stdformat
Replace string concatination with `fmt::format`
2026-07-29 13:28:58 +12:00
Scott Mansell
475f35e2fa Merge pull request #14747 from AdmiralCurtiss/dsp-hle-oob
HW/DSPHLE/AXVoice: Check array bounds in ApplyUpdatesForMs()
2026-07-29 13:26:27 +12:00
Scott Mansell
443094f020 Merge pull request #14751 from JoshuaVandaele/vendor-flatpak-sdl
Flatpak: Use vendored-in SDL
2026-07-29 13:26:04 +12:00
Scott Mansell
fa80e2bc9a Merge pull request #14754 from JoshuaVandaele/cmakeupd-sdl-3412
Externals/SDL: Update to release-3.4.12
2026-07-29 13:25:29 +12:00
Scott Mansell
3c4659ce34 Merge pull request #14757 from JoshuaVandaele/cmake-version-check
CMake: Improve our version checking
2026-07-29 13:24:59 +12:00
Scott Mansell
bc6688c0aa Merge pull request #14752 from JoshuaVandaele/about-sdl
AboutDialog: Report the SDL version being used
2026-07-29 13:23:16 +12:00
Dr. Dystopia
08e183d322 Replace string concatination with fmt::format 2026-07-28 12:39:54 +02:00
Scott Mansell
4782a04c20 GCZ: use 64-bit for m_data_offset
A malicious GCZ file could probably force this to be negative.
Shouldn't cause any issues other than file read failures, but need to fix
because it is causing errors on MSVC.
2026-07-28 19:44:49 +12:00
Scott Mansell
feeb36bf07 GCZ: validate while loading 2026-07-28 19:44:49 +12:00
Scott Mansell
ffb0e2c594 GCZ: Don't trust block_num either
SectorReader::ReadChunk does do some validation on it, but it only
checks against the original disc size (reported by the GCZ file).
It has no idea how many blocks the header claimed the disc had.

A maliciously crafted GCZ file could trigger read overflows off the end
of the m_block_pointers/m_hashes arrays.
2026-07-28 19:44:49 +12:00
Scott Mansell
a3740b5f71 GCZ: Don't trust GetBlockCompressedSize
It comes unverified from the file, and a maliciously crafted file could
trigger not one, but two buffer overflows in the heap.
2026-07-28 19:44:49 +12:00
Scott Mansell
8fb464040c DolReader: Fix integer wraparound
A malicious dol could theoretically use integer wraparound to bypass
bounds checking and cause DolReader to read past the end of m_bytes.

Could result in crashes, wasting large amounts of memory, or even the
disclosure of heap memory contents.
2026-07-27 21:15:51 +12:00
Joshua Vandaële
55c015e6ac AchievementApprovedHash: Automatically generate hash using CMake 2026-07-27 07:09:11 +02:00
slick-daddy
aa2167d473 Return m_devices directly in GetAllDevices(). 2026-07-27 06:15:36 +03:00
Matheus Willder
7788e6824e Update codes to unlock Black Edition and Collector's Edition in Need for Speed 2026-07-26 16:26:12 +00:00
JosJuice
d742aa8b4c Merge pull request #14756 from JoshuaVandaele/gcc16-warns-fix
Resolve various warnings
2026-07-26 17:37:10 +02:00
matellush
47d82300a9 Flatpak: Bump libevdev to the latest version 2026-07-25 19:22:35 +02:00
Joshua Vandaële
24361f49d1 CMake: Enforce minimum stdlib versions 2026-07-25 06:10:43 +02:00