Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-08-25 03:46:01 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

NetPlay: Fix Wii save banner buffer overflow

Browse Source 
Reported by MrSynAckster.
This commit is contained in:
JosJuice
2026-05-30 16:35:16 +02:00
parent 43210d1430
commit 747e1e0d92
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/Core/NetPlayClient.cpp
View File

@@ -1211,7 +1211,7 @@ void NetPlayClient::OnSyncSaveDataWii(sf::Packet& packet)
for (u8& byte : header.md5)
packet >> byte;
packet >> header.unk2;
for (size_t i = 0; i < header.banner_size; i++)
for (size_t i = 0; i < std::min<size_t>(header.banner_size, sizeof(header.banner)); i++)
packet >> header.banner[i];
// BkHeader

2
Source/Core/Core/NetPlayServer.cpp
View File

@@ -1976,7 +1976,7 @@ bool NetPlayServer::SyncSaveData(const SaveSyncInfo& sync_info)
for (u8 byte : header->md5)
pac << byte;
pac << header->unk2;
for (size_t i = 0; i < header->banner_size; i++)
for (size_t i = 0; i < std::min<size_t>(header->banner_size, sizeof(header->banner)); i++)
pac << header->banner[i];
// BkHeader