Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-07-16 00:42:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixes: make dolreader validate section addresses and sizes

Browse Source 
IOS and IPL reject non-32byte aligned sections
This commit is contained in:
DacoTaco 2026-05-13 20:26:47 +02:00
parent d0d354fbed
commit 21d44f32ba
No known key found for this signature in database
GPG Key ID: EEF7287E53A029AD
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Source/Core/Core/Boot/DolReader.cpp
View File

@ -53,6 +53,14 @@ bool DolReader::Initialize(std::span<const u8> buffer)
{
if (m_dolheader.textSize[i] != 0)
{
if ((m_dolheader.textAddress[i] & 31) != 0 || (m_dolheader.textSize[i] & 31) != 0)
{
ERROR_LOG_FMT(BOOT,
"Text section {} is not 32-byte aligned: address = 0x{:08x}, size = 0x{:x}",
i, m_dolheader.textAddress[i], m_dolheader.textSize[i]);
return false;
}
if (buffer.size() < m_dolheader.textOffset[i] + m_dolheader.textSize[i])
return false;
@ -80,6 +88,14 @@ bool DolReader::Initialize(std::span<const u8> buffer)
{
u32 section_size = m_dolheader.dataSize[i];
u32 section_offset = m_dolheader.dataOffset[i];
if ((m_dolheader.dataAddress[i] & 31) != 0 || (section_size & 31) != 0)
{
ERROR_LOG_FMT(BOOT,
"Data section {} is not 32-byte aligned: address = 0x{:08x}, size = 0x{:x}",
i, m_dolheader.dataAddress[i], section_size);
return false;
}
if (buffer.size() < section_offset)
return false;