Leahnaya/bemanitools
1
0
Fork 0
mirror of https://github.com/djhackersdev/bemanitools.git synced 2026-04-19 16:17:34 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Clarify p4io_cmd_init's lack of response checking

Browse Source
This commit is contained in:
Will Toohey 2021-04-06 20:30:47 +10:00
parent e266aed1f9
commit 7b5e4772ea
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/p4iodrv/device.c
View File

@ -87,7 +87,10 @@ static bool p4io_send(struct p4iodrv_ctx *ctx, uint8_t cmd) {
return p4io_transfer(ctx, cmd, NULL, 0, NULL, 0);
}
// real IO does not check the return value, so neither do we
// Real IO does not check the return value, so neither do we.
// Even if we were to check the return value here, the reset command returns a 0
// byte response - not even an "OK" status, 0 bytes in total. That technically
// should be raising an error, but because reset is a special case it's ignored
static void p4io_cmd_init(struct p4iodrv_ctx *ctx) {
p4io_send(ctx, P4IO_CMD_INIT);
}