Leahnaya/account
1
0
Fork 0
mirror of https://github.com/PretendoNetwork/account.git synced 2026-09-14 22:37:22 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove redundant transactions

Browse Source 
We can update the data directly without a transaction.
This commit is contained in:
Daniel López Guimaraes
2023-11-05 12:08:47 +00:00
parent aa480673d2
commit dc7d44baf0
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/middleware/nasc.ts
View File

@@ -124,14 +124,9 @@ async function NASCMiddleware(request: express.Request, response: express.Respon
// * So, the linked PIDs won't have the user's PID
// * anymore.
if (!linkedPIDs.includes(pid)) {
const session: mongoose.ClientSession = await databaseConnection().startSession();
await session.startTransaction();
device.linked_pids.push(pid);
await device.save({ session });
await session.commitTransaction();
await device.save();
}
}
}
@@ -148,9 +143,6 @@ async function NASCMiddleware(request: express.Request, response: express.Respon
// * have the same serial number and MAC address.
// * Do we want this? If not, are there other solutions?
if (!device && pid) {
const session: mongoose.ClientSession = await databaseConnection().startSession();
await session.startTransaction();
device = new Device({
model,
serial: serialNumber,
@@ -160,9 +152,7 @@ async function NASCMiddleware(request: express.Request, response: express.Respon
linked_pids: [pid]
});
await device.save({ session });
await session.commitTransaction();
await device.save();
}
if (titleID === '0004013000003202') {