Leahnaya/UniVRM
1
0
Fork 0
mirror of https://github.com/vrm-c/UniVRM.git synced 2026-09-10 21:09:08 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

後方互換のためのバージョンチェックがループの中にあるのを外に出した。結果をキャッシュした

Browse Source 
* List.Assign が遅いようなので書き直し
* Vertices もCapcity計算する
This commit is contained in:
ousttrue
2022-02-17 19:28:07 +09:00
parent 258cc1925b
commit 48670c4267
3 changed files with 48 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Assets/UniGLTF/Runtime/Extensions/ArrayExtensions.cs
View File

@@ -100,14 +100,6 @@ namespace UniGLTF
}
}
public static class ListExtensions
{
public static void Assign<T>(this List<T> dst, NativeArray<T> src, Func<T, T> pred) where T : struct
{
dst.Capacity = src.Length;
dst.AddRange(src.Select(pred));
}
}
public static class ArraySegmentExtensions
{

13
Assets/UniGLTF/Runtime/Extensions/glTFExtensions.cs
View File

@@ -135,11 +135,22 @@ namespace UniGLTF
}
}
static Dictionary<(string, int, int), bool> s_cache = new Dictionary<(string, int, int), bool>();
public static bool IsGeneratedUniGLTFAndOlder(this glTF gltf, int major, int minor)
{
if (gltf == null) return false;
if (gltf.asset == null) return false;
return IsGeneratedUniGLTFAndOlderThan(gltf.asset.generator, major, minor);
var key = (gltf.asset.generator, major, minor);
if (s_cache.TryGetValue(key, out bool isOlder))
{
return isOlder;
}
var result = IsGeneratedUniGLTFAndOlderThan(gltf.asset.generator, major, minor);
s_cache.Add(key, result);
return result;
}
}
}

56
Assets/UniGLTF/Runtime/UniGLTF/IO/MeshIO/MeshContext.cs
View File

@@ -164,23 +164,26 @@ namespace UniGLTF
return src;
}
int GetIndicesCapacity(GltfData data, glTFMesh gltfMesh)
(int VertexCapacity, int IndexCapacity) GetCapacity(GltfData data, glTFMesh gltfMesh)
{
var count = 0;
var vertexCount = 0;
var indexCount = 0;
foreach (var primitive in gltfMesh.primitives)
{
var positions = data.GLTF.accessors[primitive.attributes.POSITION];
vertexCount += positions.count;
if (primitive.indices == -1)
{
var positions = data.GLTF.accessors[primitive.attributes.POSITION];
count += positions.count;
indexCount += positions.count;
}
else
{
var accessor = data.GLTF.accessors[primitive.indices];
count += accessor.count;
indexCount += accessor.count;
}
}
return count;
return (vertexCount, indexCount);
}
/// <summary>
@@ -194,7 +197,9 @@ namespace UniGLTF
/// <returns></returns>
public void ImportMeshIndependentVertexBuffer(GltfData data, glTFMesh gltfMesh, IAxisInverter inverter)
{
_indices.Capacity = GetIndicesCapacity(data, gltfMesh);
(_vertices.Capacity, _indices.Capacity) = GetCapacity(data, gltfMesh);
bool isOldVersion = data.GLTF.IsGeneratedUniGLTFAndOlder(1, 16);
foreach (var primitives in gltfMesh.primitives)
{
@@ -220,7 +225,7 @@ namespace UniGLTF
var texCoord0 = Vector2.zero;
if (texCoords0 != null)
{
if (data.GLTF.IsGeneratedUniGLTFAndOlder(1, 16))
if (isOldVersion)
{
#pragma warning disable 0612
// backward compatibility
@@ -341,7 +346,9 @@ namespace UniGLTF
/// <returns></returns>
public void ImportMeshSharingVertexBuffer(GltfData data, glTFMesh gltfMesh, IAxisInverter inverter)
{
_indices.Capacity = GetIndicesCapacity(data, gltfMesh);
(_vertices.Capacity, _indices.Capacity) = GetCapacity(data, gltfMesh);
var isOldVersion = data.GLTF.IsGeneratedUniGLTFAndOlder(1, 16);
{
// 同じVertexBufferを共有しているので先頭のモノを使う
@@ -364,7 +371,7 @@ namespace UniGLTF
var texCoord0 = Vector2.zero;
if (texCoords0 != null)
{
if (data.GLTF.IsGeneratedUniGLTFAndOlder(1, 16))
if (isOldVersion)
{
#pragma warning disable 0612
texCoord0 = texCoords0.Value[i].ReverseY();
@@ -405,29 +412,38 @@ namespace UniGLTF
// blendshape
if (primitives.targets != null && primitives.targets.Count > 0)
{
_blendShapes.AddRange(primitives.targets.Select((x, i) => new BlendShape(i.ToString())));
for (int i = 0; i < primitives.targets.Count; ++i)
{
//var name = string.Format("target{0}", i++);
var primTarget = primitives.targets[i];
var blendShape = _blendShapes[i];
var blendShape = new BlendShape(i.ToString());
_blendShapes.Add(blendShape);
var primTarget = primitives.targets[i];
if (primTarget.POSITION != -1)
{
blendShape.Positions.Assign(
data.GetArrayFromAccessor<Vector3>(primTarget.POSITION), inverter.InvertVector3);
blendShape.Positions = data.GetArrayFromAccessor<Vector3>(primTarget.POSITION).ToList();
for (var j = 0; j < blendShape.Positions.Count; ++j)
{
blendShape.Positions[j] = inverter.InvertVector3(blendShape.Positions[j]);
}
}
if (primTarget.NORMAL != -1)
{
blendShape.Normals.Assign(
data.GetArrayFromAccessor<Vector3>(primTarget.NORMAL), inverter.InvertVector3);
blendShape.Normals = data.GetArrayFromAccessor<Vector3>(primTarget.NORMAL).ToList();
for (var j = 0; j < blendShape.Positions.Count; ++j)
{
blendShape.Normals[j] = inverter.InvertVector3(blendShape.Normals[j]);
}
}
if (primTarget.TANGENT != -1)
{
blendShape.Tangents.Assign(
data.GetArrayFromAccessor<Vector3>(primTarget.TANGENT), inverter.InvertVector3);
blendShape.Tangents = data.GetArrayFromAccessor<Vector3>(primTarget.TANGENT).ToList();
for (var j = 0; j < blendShape.Tangents.Count; ++j)
{
blendShape.Tangents[j] = inverter.InvertVector3(blendShape.Tangents[j]);
}
}
}
}