Fix warnings

This commit is contained in:
WarmUpTill 2023-01-07 19:24:49 +01:00 committed by WarmUpTill
parent c96c81cf1d
commit fd4476c0b3
4 changed files with 7 additions and 9 deletions

View File

@ -282,7 +282,7 @@ std::string MacroActionAudio::GetShortDesc() const
static inline void populateActionSelection(QComboBox *list)
{
for (const auto [action, name] : actionTypes) {
for (const auto &[action, name] : actionTypes) {
if (action == MacroActionAudio::Action::MONITOR) {
if (obs_audio_monitoring_available()) {
list->addItem(obs_module_text(name.c_str()),

View File

@ -189,7 +189,7 @@ bool MacroActionRandomEdit::ShouldShowAllowRepeat()
return false;
}
const auto macro = _entryData->_macros[0];
for (const auto m : _entryData->_macros) {
for (const auto &m : _entryData->_macros) {
if (macro.get() != m.get()) {
return true;
}

View File

@ -479,18 +479,17 @@ void MacroConditionAudioEdit::UpdateEntryData()
_checkTypes->setCurrentIndex(_checkTypes->findData(
static_cast<int>(_entryData->_checkType)));
switch (_entryData->_checkType) {
case MacroConditionAudio::Type::OUTPUT_VOLUME:
case MacroConditionAudio::Type::BALANCE:
if (_entryData->_checkType ==
MacroConditionAudio::Type::OUTPUT_VOLUME ||
_entryData->_checkType == MacroConditionAudio::Type::BALANCE) {
populateOutputConditionSelection(_condition);
_condition->setCurrentIndex(
static_cast<int>(_entryData->_outputCondition));
break;
case MacroConditionAudio::Type::CONFIGURED_VOLUME:
} else if (_entryData->_checkType ==
MacroConditionAudio::Type::CONFIGURED_VOLUME) {
populateVolumeConditionSelection(_condition);
_condition->setCurrentIndex(
static_cast<int>(_entryData->_volumeCondition));
break;
}
UpdateVolmeterSource();

View File

@ -46,7 +46,6 @@ void VolControl::VolumeChanged()
void VolControl::SliderChanged(int)
{
float prev = obs_source_get_volume(source);
updateText();
}