Leahnaya/SceneSwitcher
1
0
Fork 0
mirror of https://github.com/WarmUpTill/SceneSwitcher.git synced 2026-03-21 17:34:57 -05:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Add change count to var tab tooltip

Browse Source
This commit is contained in:
Przemek Pawlas 2024-03-02 19:35:07 +01:00 committed by WarmUpTill
parent eec9244e4c
commit 7fa0ba3355
5 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data/locale/en-US.ini
View File

@ -84,7 +84,7 @@ AdvSceneSwitcher.variableTab.lastUsed.text.never="Never"
AdvSceneSwitcher.variableTab.lastChanged.header="Last changed"
AdvSceneSwitcher.variableTab.lastChanged.text="%1 seconds ago"
AdvSceneSwitcher.variableTab.lastChanged.text.none="No change since launch"
AdvSceneSwitcher.variableTab.lastChanged.tooltip="Previous value: %1"
AdvSceneSwitcher.variableTab.lastChanged.tooltip="Times changed: %1\n\nPrevious value: %2"
; Macro Tab
AdvSceneSwitcher.macroTab.title="Macro"

3
lib/variables/variable-tab.cpp
View File

@ -85,7 +85,8 @@ static QString formatLastChangedTooltip(Variable *variable)
QString tooltip = obs_module_text(
"AdvSceneSwitcher.variableTab.lastChanged.tooltip");
return tooltip.arg(QString::fromStdString(variable->GetPreviousValue()));
return tooltip.arg(QString::number(variable->GetValueChangeCount()))
.arg(QString::fromStdString(variable->GetPreviousValue()));
}
static void addVariableRow(QTableWidget *table, Variable *variable)

3
lib/variables/variable.cpp
View File

@ -113,10 +113,11 @@ void Variable::UpdateLastUsed() const
_lastUsed = std::chrono::high_resolution_clock::now();
}
void Variable::UpdateLastChanged() const
void Variable::UpdateLastChanged()
{
if (_previousValue != _value) {
_lastChanged = std::chrono::high_resolution_clock::now();
++_valueChangeCount;
}
}

4
lib/variables/variable.hpp
View File

@ -38,16 +38,18 @@ public:
void SetValue(const std::string &value);
void SetValue(double value);
SaveAction GetSaveAction() const { return _saveAction; }
int GetValueChangeCount() const { return _valueChangeCount; }
std::optional<uint64_t> GetSecondsSinceLastUse() const;
std::optional<uint64_t> GetSecondsSinceLastChange() const;
void UpdateLastUsed() const;
void UpdateLastChanged() const;
void UpdateLastChanged();
private:
SaveAction _saveAction = SaveAction::DONT_SAVE;
std::string _value = "";
std::string _previousValue = "";
std::string _defaultValue = "";
int _valueChangeCount = 0;
mutable std::chrono::high_resolution_clock::time_point _lastUsed;
mutable std::chrono::high_resolution_clock::time_point _lastChanged;

5
tests/test-variable.cpp
View File

@ -9,15 +9,20 @@ TEST_CASE("Variable", "[variable]")
REQUIRE_FALSE(variable.GetSecondsSinceLastUse());
REQUIRE(variable.Value() == "");
REQUIRE(variable.GetPreviousValue() == "");
REQUIRE(variable.GetDefaultValue() == "");
REQUIRE(variable.GetSaveAction() ==
advss::Variable::SaveAction::DONT_SAVE);
REQUIRE(variable.GetValueChangeCount() == 0);
variable.SetValue("testing");
REQUIRE(variable.Value() == "testing");
REQUIRE(variable.GetPreviousValue() == "");
REQUIRE(variable.GetValueChangeCount() == 1);
variable.SetValue(123);
REQUIRE(variable.Value() == "123");
REQUIRE(variable.GetPreviousValue() == "testing");
variable.SetValue(123.0);
REQUIRE(variable.Value() == "123");