Leahnaya/SceneSwitcher
1
0
Fork 0
mirror of https://github.com/WarmUpTill/SceneSwitcher.git synced 2026-08-16 06:08:12 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix freeze on setting hide/show transition

Browse Source 
A "private" copy of the transition source has to be used for show and
hide transitions as otherwise this can lead to an OBS freeze the next
time the show / hide transition is used
This commit is contained in:
WarmUpTill
2022-06-12 17:49:35 +02:00
committed by WarmUpTill
parent e89343b03e
commit 1665841589
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/macro-action-transition.cpp
View File

@@ -58,14 +58,17 @@ void MacroActionTransition::SetSourceTransition(bool show)
show ? obs_sceneitem_set_show_transition_duration
: obs_sceneitem_set_hide_transition_duration;
obs_source_t *transition =
auto transition =
obs_weak_source_get_source(_transition.GetTransition());
obs_source_t *t = obs_source_create_private(
obs_source_get_id(transition), obs_source_get_name(transition),
nullptr);
obs_source_release(transition);
const auto items = _source.GetSceneItems(_scene);
for (auto &item : items) {
if (_setTransitionType) {
setTransitionFunc(item, transition);
setTransitionFunc(item, t);
}
if (_setDuration) {
setDurationFunc(item, _duration.seconds * 1000);
@@ -73,7 +76,7 @@ void MacroActionTransition::SetSourceTransition(bool show)
obs_sceneitem_release(item);
}
obs_source_release(transition);
obs_source_release(t);
#else
blog(LOG_WARNING, "Setting hide / show transition not supported!");
#endif