Ludwig Nussel 2009-10-18 05:34:18 PDT
src/joystick/linux/SDL_sysjoystick.c has some problems:
- test_bit() might break with strict aliasing
- test_bit() assumes array is Uint32 but its actually "unsigned long"
on 64bit systems sizeof(long) != sizeof(Uint32).
- the keybit array is too small
- the arrays are unitialized so the number of
detected buttons is quite random
Jesse Anders 2009-10-17 14:17:25 PDT
In VC++, the build script that creates SDL_config.h and SDL_revision.h fails
when the project directory path includes spaces. For example, if the project
directory path is:
c:\Documents and Settings\Jesse\My Documents\Visual Studio 2008\Projects\SDL
1.3\VisualC\SDL\
The following error is generated:
'and' is not recognized as an internal or external command
Placing all paths in quotes fixes this.
Eric Wing to Sam
Here's another patch for Xcode-iPhone for 1.3.
This has been sitting for awhile too, so you may want to test.
Contains mostly small changes, but tries to unify how I do some of the script stages with the Mac version.
Eric Wing to Sam
I've been sitting on this too long. I need to push.
It's untested because of the unrelated crashing bug I've been experiencing.
Also have a fix for SIZEOF_VOIDP in the config for both iPhone and Mac.
I updated and wanted to compile SDL, but it does not work.
The reason is the new pre-build step.
Currently it says:
"if exist $(SolutionDir)\..\include\SDL_config.h goto SDLCONFIGOKAY
echo Copying SDL_config_win32.h to SDL_config.h...
copy $(SolutionDir)\..\include\SDL_config_win32.h $(SolutionDir)\..\include\SDL_config.h
:SDLCONFIGOKAY
if exist $(SolutionDir)\..\include\SDL_revision.h goto SDLREVISIONOKAY
echo Creating stub SDL_revision.h file...
echo #define SDL_REVISION 0 >$(SolutionDir)\..\include\SDL_revision.h
:SDLREVISIONOKAY"
So ... the problem with this lines is, that they lookup the SolutionDir...
I think it should use the ProjectDir here!
I - for example - want to use SDL within my engine...
So my engine is the solutionDir...not SDL...SDL is just a sub-project.
I think you should change this, shouldn't you?!
Regards,
Stefan
If this causes problems on any compiler, please report a bug to
http://bugzilla.libsdl.org/
and include the platform and version of compiler you're using.
