Leahnaya/SDL
1
0
Fork 0
mirror of https://github.com/yawut/SDL.git synced 2026-04-24 15:26:55 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed buffer overflows in resamplers.

Browse Source 
I'm not confident this is a complete fix, but I'm not confident the current
 resamplers are really worth keeping at all, either.
This commit is contained in:
Ryan C. Gordon 2009-12-28 08:28:24 +00:00
parent 6491208ef7
commit d3cffb3167
2 changed files with 205 additions and 201 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

400
src/audio/SDL_audiotypecvt.c
View File

File diff suppressed because it is too large Load Diff

6
src/audio/sdlgenaudiocvt.pl
View File

@ -537,15 +537,19 @@ ${sym}(SDL_AudioCVT * cvt, SDL_AudioFormat format)
const int dstsize = cvt->len_cvt $lencvtop $multiple;
EOF
my $endcomparison = '!=';
# Upsampling (growing the buffer) needs to work backwards, since we
# overwrite the buffer as we go.
if ($upsample) {
$endcomparison = '>'; # dst > target
print <<EOF;
$fctype *dst = (($fctype *) (cvt->buf + dstsize)) - $channels;
const $fctype *src = (($fctype *) (cvt->buf + cvt->len_cvt)) - $channels;
const $fctype *target = ((const $fctype *) cvt->buf) - $channels;
EOF
} else {
$endcomparison = '<'; # dst < target
print <<EOF;
$fctype *dst = ($fctype *) cvt->buf;
const $fctype *src = ($fctype *) cvt->buf;
@ -562,7 +566,7 @@ EOF
}
print <<EOF;
while (dst != target) {
while (dst $endcomparison target) {
EOF
for (my $i = 0; $i < $channels; $i++) {