Fixed bug 1403 - Creating a window with resizable flags may crash

jordirovira 2012-01-28 12:07:39 PST

in SDL_x11window around 520:

    /* Setup the normal size hints */
    if (!(window->flags & SDL_WINDOW_RESIZABLE)) {
        sizehints.min_width = sizehints.max_width = window->w;
        sizehints.min_height = sizehints.max_height = window->h;
        sizehints.flags = PMaxSize | PMinSize;
    }
    sizehints.x = window->x;
    sizehints.y = window->y;
    sizehints.flags |= USPosition;

the sizehints.flags member is not initizalised if it doesn't enter the
conditional. It is as easy as setting it to zero before the conditional.
This commit is contained in:
Sam Lantinga 2012-02-03 22:24:33 -05:00
parent c7588fa928
commit b42c90e65c

View File

@ -501,10 +501,11 @@ X11_CreateWindow(_THIS, SDL_Window * window)
}
/* Setup the normal size hints */
sizehints.flags = 0;
if (!(window->flags & SDL_WINDOW_RESIZABLE)) {
sizehints.min_width = sizehints.max_width = window->w;
sizehints.min_height = sizehints.max_height = window->h;
sizehints.flags = PMaxSize | PMinSize;
sizehints.flags |= (PMaxSize | PMinSize);
}
sizehints.x = window->x;
sizehints.y = window->y;