Leahnaya/SDL
1
0
Fork 0
mirror of https://github.com/yawut/SDL.git synced 2026-08-20 07:44:03 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add input validation and null checking to SDL_Get/SetWindowData [reported by Joseph T.]

Browse Source
This commit is contained in:
Andreas Schiffler
2013-04-02 08:38:52 -07:00
parent e52fbd7243
commit 8de86784a7
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/video/SDL_video.c
View File

@@ -1425,11 +1425,17 @@ SDL_SetWindowData(SDL_Window * window, const char *name, void *userdata)
SDL_WindowUserData *prev, *data;
CHECK_WINDOW_MAGIC(window, NULL);
/* Input validation */
if (name == NULL || SDL_strlen(name) == 0) {
SDL_InvalidParamError("name");
return NULL;
}
/* See if the named data already exists */
prev = NULL;
for (data = window->data; data; prev = data, data = data->next) {
if (SDL_strcmp(data->name, name) == 0) {
if (data->name && SDL_strcmp(data->name, name) == 0) {
void *last_value = data->data;
if (userdata) {
@@ -1467,8 +1473,14 @@ SDL_GetWindowData(SDL_Window * window, const char *name)
CHECK_WINDOW_MAGIC(window, NULL);
/* Input validation */
if (name == NULL || SDL_strlen(name) == 0) {
SDL_InvalidParamError("name");
return NULL;
}
for (data = window->data; data; data = data->next) {
if (SDL_strcmp(data->name, name) == 0) {
if (data->name && SDL_strcmp(data->name, name) == 0) {
return data->data;
}
}