Leahnaya/SDL
1
0
Fork 0
mirror of https://github.com/yawut/SDL.git synced 2026-09-09 17:46:31 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

XGetWindowProperty() can report success but still give you a NULL pointer.

Browse Source 
Thanks to Joseph Toppi for the fix!
This commit is contained in:
Ryan C. Gordon
2011-10-22 02:13:35 -04:00
parent 756aae4a51
commit 1871363aac
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/video/x11/SDL_x11window.c
View File

@@ -593,14 +593,14 @@ X11_GetWindowTitle(_THIS, Window xwindow)
status = XGetWindowProperty(display, xwindow, data->_NET_WM_NAME,
0L, 8192L, False, data->UTF8_STRING, &real_type, &real_format,
&items_read, &items_left, &propdata);
if (status == Success) {
if (status == Success && propdata) {
title = SDL_strdup(SDL_static_cast(char*, propdata));
XFree(propdata);
} else {
status = XGetWindowProperty(display, xwindow, XA_WM_NAME,
0L, 8192L, False, XA_STRING, &real_type, &real_format,
&items_read, &items_left, &propdata);
if (status == Success) {
if (status == Success && propdata) {
title = SDL_iconv_string("UTF-8", "", SDL_static_cast(char*, propdata), items_read+1);
} else {
title = SDL_strdup("");