Problem 1: syntax error in text_helper
Fix 1: single quotes instead of double quotes
Problem 2: the ground shifted beneath our feet with the devkitpro/devkitARM base image again.
The --break-system-packages option no longer exists on pip install.
Fix 2: Use a specific tag of the devkitpro/devkitARM docker image to ensure this won't happen again.
Split up data-generator into payload-generator (PTGB) and table-generator (PCCS)
The reason for this is because we don't want the dependencies to the payload stuff in PCCS.
And the tables are embedded inside libPCCS now.
Because we want to use libPCCS as a proper static lib, we now use its new Makefile to build it
before we build Poke_Transporter_GB.
- Fix make clean by adding -f flag when removing output.json
- Fix broken compress_lz10.sh script: it had a check to avoid compressing when the
input bin file hasn't changed. But the -nt operator also returns false if the output
file doesn't exist.
- Fix compilation error on conflicting u32 typedef: libtonc defines one and so does data-generator.
We shouldn't redefine it if the one from libtonc exists. The one in data-generator exists for compiling
the tool for pc.
- Fix Dockerfile. For some reason the Dockerfile was now failing because Ubuntu manages the python pip
packages. I fixed it with the --break-system-packages shortcut. It should be fine.
LZ10 decompression is builtin to the GBA's bios, so we don't need ZX0. It's also significantly faster
(618 usec instead of 2311 usec in my personal benchmark code for decompression of the same data)
And it seems like by doing so, we saved 1 KB as well!
So, seems like replacing ZX0 is the right move.
The reason I didn't initially is because I misunderstood the documentation. I assumed LZ77UnCompWram could only uncompress into EWRAM, not IWRAM.
But it turns out it can do both.
And using standardized tools is usually better than using a custom implementation.
The only downside of this right now, is that we can no longer stream text tables through a smaller buffer than the entire decompressed size.
Anyway, things seem to work fine, so bye bye ZX0. It's been fun.
This commit moves payload_builder and the z80_asm code to the data-generator subproject in order to generate the gameboy payloads
at compile time instead of at runtime.
In addition, we select a couple of base payloads (more than 1 for compressibility's sake) and generate binary patches to transform them into
other payloads. We then generate a binary file with both the base payload and binary patches and compress these files with zx0.
This reduces the rom size by about 8 KB.