Update libpokemegb git submodule to fix bug

Browse Source

Bug was reported by /u/imranFZakhaev on reddit:

When adding a pokémon to a save with a full party, the behaviour is
completely broken.

Not only did we add a pokémon to every box, but it also would be a
completely different one or even crash the game when trying to access
the box.

Fixes:

- Stop after adding a pokemon to a box. Don't add it to all.
- In commit 77d5d15 I added a ::setPokemon function and reworked the
  Gen1Box::add() function to use it. That's where it went wrong:

  in the add() function, we would modify the number_of_pokemon counter
  of the box, but not manipulate the species list and write it.
  Then in the setPokemon() function, we would read the box metadata and
  correct it because the number did not match the species list. This is
  what went wrong.

  To fix it, I just had to modify the species list in the add() function
  as well again.

...

This commit is contained in:

Philippe Symons

2024-07-26 19:58:13 +02:00

parent 55cf13d0c6

commit 39d7c31831

1 changed files with 1 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

2

libpokemegb

Submodule libpokemegb updated: b275d12a97...7ac7c29f3e