Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-05-12 23:06:58 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
cb0bbe889e
PKHeX/Tests/PKHeX.Core.Tests/Legality/Legal/General
History
Kurt 416f5fe183 Check Winning/Victory ribbons for gen3 origin based on encounter 
Closes #2990 ty @Atrius97 !

Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly.

Rewrite the national ribbon check for clarity
Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon.

Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 16:23:17 -07:00
..
Ribbons Check Winning/Victory ribbons for gen3 origin based on encounter 2020-09-18 16:23:17 -07:00
004 - CHARMANDER - D5EF.pk1 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
124 - ZYNX - 70DF498A2E1D.pk3 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
172 - Egg - 7D3CF55CFC10.pk4 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
183 - 알 - AA4E3344817C.pk5 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
235 - 알 - 10DB.pk2 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
236 - Oeuf - 5E05C020CB44.pk4 Update test case for g4 fr egg name 2020-08-26 13:36:13 -07:00
236 - 알 - F55CC3F29788.pk5 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
292 - SHEDINJA - 4889A0E852EE.pk3 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
300 - Egg - 0673311A3560.pk5 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
300 - Uovo - 0C910B68370A.pk4 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
343 - 알 - 4569F88A9BCE.pk5 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
479 - Ei - B7178C463B60.pk4 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
479 ★ - 알 - BE0D0000000A.pk5 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
610 - キバゴ - 6F91B110EED1.pk5 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
645-01 - Landorus - 57BA472C4EB8.pk6 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00