PKHeX/Tests/PKHeX.Core.Tests/Legality/Legal
Kurt 416f5fe183 Check Winning/Victory ribbons for gen3 origin based on encounter
Closes #2990 ty @Atrius97 !

Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly.

Rewrite the national ribbon check for clarity
Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon.

Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 16:23:17 -07:00
..
General Check Winning/Victory ribbons for gen3 origin based on encounter 2020-09-18 16:23:17 -07:00
Generation 1 Tradeback Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
Generation 2 Fix incorrect pp counts 2019-12-26 15:28:47 -08:00
Generation 3 Fix incorrect pp counts 2019-12-26 15:28:47 -08:00
Generation 4 Add gender changed azurill evo pokewalker edge case 2019-05-15 17:14:48 -07:00
Generation 4 EncounterType Add special set operation for alph rocksmash 2019-01-27 11:08:21 -08:00
Generation 4 Transfer Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
Generation 5 Add missing filter overrides 2019-09-19 16:19:07 -07:00
Generation 6 Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974) 2020-08-21 16:35:49 -07:00
Generation 6 Static Fix Static/Gift IV method call (#2310) 2019-05-15 12:07:48 -07:00
Generation 7 Static Fix Static/Gift IV method call (#2310) 2019-05-15 12:07:48 -07:00
Generation 7 Transfer Fix incorrect pp counts 2019-12-26 15:28:47 -08:00
Generation 7 Wild Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
Generation 8 Skip SWSH untraded link trade eggs if trade-memory 2019-12-09 16:23:29 -08:00