mirror of
https://github.com/kwsch/PKHeX.git
synced 2026-05-14 16:10:36 -05:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
46 lines
1.5 KiB
C#
46 lines
1.5 KiB
C#
using System;
|
|
using System.Runtime.CompilerServices;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public static class RNGUtil
|
|
{
|
|
/// <summary>
|
|
/// Generates an IV for each RNG call using the top 5 bits of frame seeds.
|
|
/// </summary>
|
|
/// <param name="rng">RNG to use</param>
|
|
/// <param name="seed">RNG seed</param>
|
|
/// <param name="IVs">Expected IVs</param>
|
|
/// <returns>True if all match.</returns>
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
internal static bool GetSequentialIVsUInt32(this LCRNG rng, uint seed, ReadOnlySpan<uint> IVs)
|
|
{
|
|
foreach (var iv in IVs)
|
|
{
|
|
seed = rng.Next(seed);
|
|
var IV = seed >> 27;
|
|
if (IV != iv)
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Generates an IV for each RNG call using the top 5 bits of frame seeds.
|
|
/// </summary>
|
|
/// <param name="rng">RNG to use</param>
|
|
/// <param name="seed">RNG seed</param>
|
|
/// <param name="ivs">Buffer to store generated values</param>
|
|
/// <returns>Array of 6 IVs as <see cref="int"/>.</returns>
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
internal static void GetSequentialIVsInt32(this LCRNG rng, uint seed, Span<int> ivs)
|
|
{
|
|
for (int i = 0; i < 6; i++)
|
|
{
|
|
seed = rng.Next(seed);
|
|
ivs[i] = (int)(seed >> 27);
|
|
}
|
|
}
|
|
}
|
|
}
|