* Update text_ItemsG2_ja.txt
`ポイントアップ` means PP Up in Japanese, not HP Up.
HP Up is `マックスアップ`.
Updated unit tests to ensure all gen1-3 string lists are unique item names.
Gen3-5: Egg (breeding) requesting shiny now loops to match criteria.
Gen3: Add evolution nickname bypass for trash byte application
Gen3: Fix japanese OT prefill check from not actually working
Gen3: Add missing Voltorb encounter (was superseded by Wild slot, but aggressive checks since added).
Artwork Pokemon Sprites have artefacts when rendering Sprite Glow due to them having small-value ARGB pixels. PKHeX was originally designed with the assumption of pure pixels, and not blurred edges from downscaling.
Co-Authored-By: abcboy101 <16735361+abcboy101@users.noreply.github.com>
#4785#4785
HOME misapplying PLA's size fixing, fun. Seems it was fixed in 4.0.0 (after 3.2.1?) or server side. A last-minute redeem=>deposit was "fixed" to 255, so the full date range of the card is allowed to be mutated.
- Updated and revised the encountered Ground Tiles for generation 4 to match up with English in all other languages.
- Update Event Constants for some Spanish and Korean games.
- Additional translation additions, revisions, spacing adjustments, and typo fixes.
Fix box export (individual files) not including party data in the bin. Previous behavior would have 00'd party data if not force-calculated. Just calculate party stats if not present for the format. Log Database entity as party format, just to avoid using the Stored format size.
Revise gen2 odd egg declarations to group shiny eggs together, and enforce the Shiny property for object filtering. If IVs are specified, then Shininess property needs to be provided (rather than "random" which is untrue).
Simplify some logic paths for trade1/trade2. Extract some of the nuance of transferred Hiragana Dugtrio so the unit test is xref'd nicely.
also allow WA9 latam lang (get/set was defaulting to english which probably matched anyway)
add a sanity check to TryGetSpecies which was only used by Gen1 with a hardcoded language ID. maybe someone will use it in their own project, might as well prevent an exception.
Not really an issue cuz the game sets them to `0` or `1` on startup, but clearing boxes/slots should match runtime behavior. livehex after clearing boxes can result in slots that don't update until the game is rebooted. no more ;)
should probably refactor the API a little better to avoid virtual spaghetti
Circling back to my notes on formarg updating; it's not ideal to update these values automatically, as it's wiping the streak values for the current game, or if carried forward into future games. The user will have to manage them since the legality flagging now handles warning the user. Better than hiding and overwriting values to something the user can't control.
5e7fc6c817
Shifted down extrabyte edits a little more for aesthetics.
Move combobox werent as wide as the relearn moves, so +16 to make them match.
update translation resources with latest additions
PC9 in RAM is loosely deserialized, not a sequential blob. Will need to see how the json is stored in the at-rest savedata. Probably won't be something useful to directly integrate into PKHeX since it's online-only.
less designer code (-250) so I think this is a win
* Friendship moved to OT/Misc tab since it is much less relevant in current formats; HT now shows the friendship rather than flexing CurrentFriendship.
- Translations mostly complete for the UI and legality message strings in Spanish, Korean, and Traditional Chinese,
- Includes the titles for generation 5 Pass Powers, generation 6 O-Powers, as well as officially used terms for things such as Memories, Athlete Points etc.
- Some official nouns used in the Spain's Spanish translation were using a mix of LATAM terms; they've been corrected to the ones used for that version, and LATAM was corrected or retained to what it should use.
- Made some text shorter in some languages to fit the UI labels and buttons.
- A few typo corrections and additional translation text to the German, Spanish, and Korean READMEs.
