Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-05-22 21:13:33 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,161 Commits 3 Branches 98 Tags 183 MiB
b280ffcfef
Commit Graph

880 Commits

Author SHA1 Message Date
Kurt
b280ffcfef style updates 
should be pretty much it
 2018-09-14 22:37:47 -07:00
Matt
165757d590 Fix Meteorite/Mega Cuff mixup (#2120) 
Meteorite (2) is legal, Mega Cuff is not.
 2018-09-12 22:10:13 -07:00
Kurt
ff25e3cbd0 Remove illegal items from legal key items 2018-09-12 21:52:09 -07:00
Kurt
d511fccdb4 Move basement key item ID to illegal group 
no functional change, item is unobtainable but still can be 'give all'
and in permitted list
 2018-09-12 21:30:24 -07:00
Matt
fc91819410 Add XY Magikarp trade IVs (#2117) 
* Add XY Magikarp trade IVs

* Add Cosplay Pikachu IVs
 2018-09-12 11:02:11 -07:00
Kurt
0c02a0cbbc Add splitbreed mantine to pastgen alolanoffspring 
thanks kr, beast ball now recognized as legal
 2018-09-09 17:19:50 -07:00
Kurt
f444c41ee3 Remove nick req on g5 gigalith trade 
Closes #2114
 2018-09-08 10:45:30 -07:00
Kurt
d02b87a7b2 Expose checkresult properties 
can now check individual strings / identifiers in a LegalityAnalysis
object by:

var la = new LegalityAnalysis(pkm);
var parse = la.Info.Parse;
if (parse.Any(z => ReferenceEquals(z.Comment, LegalityCheckStrings.X))
...
should be faster than doing string.Contains
 2018-09-05 21:27:52 -07:00
Kurt
1750c69b01 Update pcd version distro check 
some events have fixed version IDs in the gift data

https://projectpokemon.org/home/forums/topic/47365-vgc-shiny-milotic-usa-pkhex/
 2018-09-05 16:09:30 -07:00
Kurt
cc20bb38d7 misc updates 
use arrays instead of list when capacity known
use enums for const decoration
remove unnecessary aliases
 2018-09-01 19:55:08 -07:00
Kurt
91c37ab573 Update legality check message string style 
V### names weren't enjoyable to work with; use similar verbose style as
the program message strings.

updating the translation files with the remapped variable names shortly

remap list: https://pastebin.com/jybkVDAK
 2018-09-01 14:11:12 -07:00
Kurt
1fe304e78f Rework mg nick/lang checks 
add common interface

https://projectpokemon.org/home/forums/topic/47295-bug-event-golduck-name-not-matching-species/
 2018-08-30 18:09:52 -07:00
Kurt
c6e4c39bc5 Fix gen1 single chain for gen2 tradeback scenario 
invalid mon -> make sure array is big enough for later move parsing

https://projectpokemon.org/home/forums/topic/47283-unhandled-exception-when-importing-set-from-clipboard-after-opening-gen-i-save-file/
 2018-08-29 21:58:44 -07:00
Kurt
ebae14e6ad Add unnicknamed forced languageID wc7 handling 
https://projectpokemon.org/home/forums/topic/47295-bug-event-golduck-name-not-matching-species/
another edge case
 2018-08-29 20:36:32 -07:00
Kurt
f89d9ca323 Split apart headbutt tree logic 
precompute Index & make readonly when initializing as we use Index at
least once when initializing the treesarea
 2018-08-28 15:10:08 -07:00
Kurt
f74c1e321a no mo go to yo 
pull goto default into 'when' so other cases continue to default

this is a goto free codebase ( ͡° ͜ʖ ͡°)
 2018-08-27 20:48:57 -07:00
Kurt
4dc04cb4b9 Add pelago status value check + etc 
0, [9,19] are set (didn't see 15), but there's also a switch case which
references all values 0-19.

these values are used by a 80 sbyte array (4*20) in the Resort.cro

remove usages of "goto case"
 2018-08-27 20:44:26 -07:00
Kurt
102430ebf5 Update trade nickname check 
reorder for simplicity, add test
Thanks ThePunish3D!
 2018-08-26 18:32:39 -07:00
Kurt
4656909d98 Misc reorg 
use shared class for pk1/2 setnotnicknamed
fix extendedeurope values (copypaste from extendedAmericas)
move ball out of verifiers, move nature/movetype with ball
 2018-08-26 16:29:52 -07:00
Kurt
f7b5a5579d sync missing content 
yay rename
 2018-08-26 11:29:47 -07:00
Kurt
7f87d43c41 Add enum for ball; use in checks 
Increases readability instead of using hex IDs
 2018-08-26 11:15:32 -07:00
Kurt
6a225ad091 Add mr mime to usum additions for egg balls 2018-08-26 09:43:11 -07:00
Kurt
a9f65a4617 add lock for cross thread dictionary manip 
could use concurrentdictionary but after reading some perf drawbacks vs
manual locks, just do it manually. regex checking is the real slow part,
whatever
add some comments to describe
 2018-08-25 10:48:37 -07:00
Kurt
5fe9226c62 Ignore fixed language trades for gen4 korean check 
Closes #2103
Thanks @Narithegreat !
 2018-08-22 22:36:56 -07:00
Kurt
7ccaf8783b Unban bred HA sableye 
yeah totally genderless

https://projectpokemon.org/home/forums/topic/47101-gen-v-hidden-ability-sableye/
 2018-08-20 20:08:42 -07:00
Kurt
d7f39ea343 Extract pkm searching to separate classes 
search logic can now be reused by core projects

adds option to provide extra filters run at the end (prior to clone
check)
 2018-08-16 20:06:40 -07:00
Kurt
eec14645ef Lessen string length severity on egg encounters 
Hatched eggs can have mismatched languages<->OT/Nick restrictions
 2018-08-15 15:26:42 -07:00
Kurt
5514530dfb update OT name edge case 
traded ENG->KOR egg was getting flagged
#2094
 2018-08-15 15:19:54 -07:00
Kurt
b6de41bfa7 Add OT name max length checks 
Closes #2094
 2018-08-15 14:58:55 -07:00
Kurt
bc262a7cdf Remove Plasma Fists from unsketchable 
Closes #2095
split out unsketchable moves (struggle/chatter) to separate array
remove trailing spaces (auto fixed by my visual studio plugin), add
space before comment //
 2018-08-15 14:52:25 -07:00
Kurt
57c6de2825 Add nickname length check for gen>2 
Closes #2091
 2018-08-14 20:13:15 -07:00
Kurt
6edc828cc3 misc style updates 2018-08-12 19:27:11 -07:00
Kurt
6b62dd29ee Update xy fashion edits 
different for each gender
 2018-08-08 21:27:14 -07:00
Kurt
7403c0f91a Add more pokewalker moves 
igglybuff wish, happiny heal bell, and the elemental punches to round
things out even though they can be tutored

https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234991
 2018-08-08 17:35:06 -07:00
Kurt
279c9d4665 Fix tradeback detect for gen2->1->2 evolve case 
https://projectpokemon.org/home/forums/topic/46909-certain-gen-i-moves-are-showing-invalid/

Thanks Raptor385!
 2018-08-04 13:36:05 -07:00
Kurt
53857df647 Copy addmoves special case to individual fetch 
see prior commits
 2018-08-04 10:05:47 -07:00
Kurt
0f63b0a0ee Allow bw movepool except for kyurem 
workaround provided for kyurem movepool (which is same bw-b2w2) but the
AddMoves logic with form != 0 points to the form == 0 data
Closes #2085
 2018-08-03 07:46:53 -07:00
Kurt
30a614484e Update STADIUM ot checks again 
jp: 1999 if stadium1, 2000 if stadium2
en: 2000

jp: always same OT
en: lowercase if stadium2, uppercase if stadium1

https://projectpokemon.org/home/forums/topic/46893-pkhex-bug-stadium-ot-issue/
 2018-08-03 07:38:29 -07:00
Kurt
1486b7f14a Misc style & minor tweaks 
Remove move combobox flicker hack (no longer necessary)
Add more Array.Empty usages
cache mysterygift sizes
seal some classes

no functionality changes
 2018-08-02 20:11:42 -07:00
Kurt
19a897923d Reference original encounter for sensitive checks 
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234360
thanks paf!
 2018-08-01 20:39:20 -07:00
Kurt
f4bfdb8311 Remove unnecessary empty array allocations 
yay net 4.6
read more: http://justinvp.com/2015/07/20/array-empty/
 2018-08-01 18:30:51 -07:00
Kurt
007ec93d85 Update trade nick check for non-nicknamed 
Closes #2084
 2018-07-31 17:27:28 -07:00
Kurt
cfa3479a4b Add egg experience check 
Closes #2083
 2018-07-28 18:09:29 -07:00
Kurt
c46924d220 Use wcxfull version/language restriction data 
some cards may permit being recieved on incorrect games

some wcxfulls permit games they shouldn't (tapu koko flags permit USUM
but games released after the distribution window)
lots of wcx lacking restrictions completely

tested flagging USUM rockruff & zeraora

might be worth discarding MysteryGiftVerifier and instead just using
unused fields for prior formats to supply the data.
 2018-07-27 22:26:27 -07:00
Kurt
3d0a2946eb Allow only one movepool for BW-B2W2 source 
they're both the same, but bw's pool does not have b2w2 formes
Closes #2078
 2018-07-26 21:51:11 -07:00
Kurt
c8563a3737 Respacening 
Style guidelines, handle a bunch of files
no functional change
 2018-07-26 19:34:27 -07:00
Kurt
75801e22e0 Update egg location -> encounter generating checks 
WasEgg only checks for EncounterEgg valid locations; check for any value
instead.
 2018-07-26 14:55:49 -07:00
Kurt
711157f3ea Refactoring 
Extract trainer pkm origin check to interface extension
 2018-07-25 20:40:57 -07:00
Kurt
f0fc4b0693 remove alias'd properties 2018-07-25 19:43:02 -07:00
Kurt
f0090669bb Update catch rate related logic 
#2071
 2018-07-24 19:33:42 -07:00