Kurt
6b1fff05bd
Revise gen6/7 HA banlist to account for altforms
2020-10-09 20:04:09 -07:00
Kurt
20bb2c6a49
Add some species to HA banlists (same as regular)
...
Gen6/7 have some species that can't be obtained with A4. Kinda flew under the radar due to their HA being the same as the other abilities.
2020-10-09 17:09:07 -07:00
Kurt
dfbafee506
Add call rate check for SOS hidden ability
...
Probably could just yeet the encounter data for these impossible-to-reach SOS's since they're duplicate with the non-SOS slots, but whatever.
2020-10-09 15:38:23 -07:00
Kurt
945ef24142
Add SK2 to batch editor supported types
...
Could do it via reflection but ehh
2020-10-09 14:44:12 -07:00
Kurt
706618d331
Force Hidden Power IVs for format2 imports
...
Closes #3019
2020-10-09 09:52:29 -07:00
Matt
a0d97f6f89
Unban GO Shiny Vulpix ( #3020 )
...
Autumn Event 2020
2020-10-09 08:27:48 -07:00
Kurt
9d21e5acdd
Add GUI for Capture Records
...
Accessible from Pokedex window
ur welcome matt
2020-10-08 18:06:29 -07:00
ShadowMario3
559ec76812
Fix game version for International Gen 2 events ( #3018 )
2020-10-08 15:57:19 -07:00
Kurt
7cb484834c
Handle max possible level for transferred & evolved-to-new-species
...
A Gen3 level 26 sylveon with a met level of 25 in Generation 8:
Transferred as Eevee at level 25, and leveled up to 26=>Sylveon
If we use met_level (25), we need to decrease 1 as we evolve. No, use Current Level and ensure the max isn't above the bare minimum (met level)
2020-10-08 15:35:50 -07:00
Kurt
804b85ea33
Add CaptureRecord block interaction
...
No GUI
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com >
2020-10-08 15:28:25 -07:00
Kurt
3686ee9ec4
Set suggested Encounter Type on Met Location click too
...
Closes #3010
2020-10-08 15:01:23 -07:00
Kurt
ea9076ad4c
Account for revised evolution conditions for gen4 new-evos in gen8+
2020-10-08 14:28:34 -07:00
Kurt
9e4ec32e94
Revise nickname check; language-source retained in gen8+
2020-10-08 14:14:59 -07:00
Kurt
b4eeaf847c
Disallow lang-traded eggs mismatching nickname on gen8+
...
Starting in Generation 8, hatched language-traded eggs will take the Language from the trainer that hatched it.
Transferring from Gen7->Gen8 realigns the Nickname string to the Language, if not nicknamed.
2020-10-08 14:01:36 -07:00
Kurt
6efe279ffe
Refresh nickname on transfer
...
Mimics official behavior
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com >
2020-10-08 14:00:17 -07:00
Kurt
478cb33788
Unshorten parameter names
...
lang->language
nick->nickname
2020-10-08 13:59:58 -07:00
Kurt
0de76b57b1
Handle incorrect bred stunfisk local form value
...
The game uses 0x5E if 0x5A+everstone, otherwise it uses 0x58
For determining the seed species-form, we want to use everstone breeds as that resolves to the correct species-form values.
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com >
Co-Authored-By: Marty-D <1645989+Marty-D@users.noreply.github.com >
2020-10-08 13:12:25 -07:00
ShadowMario3
482dbf0b17
Update Encounters2.cs ( #3017 )
...
Fix OT for PCNY eggs
2020-10-08 08:32:18 -07:00
ShadowMario3
9516458491
Changed es1e to allow multi-OT ( #3016 )
...
* es1e allows multi-OT, merged Stadium Psyduck OTs, added Yoshira Mew
* fixed spacing on Gen 1 event OTs
2020-10-08 07:10:10 -07:00
ShadowMario3
7aac80769b
Update Encounters2.cs ( #3015 )
...
Met + Current level data for non-Egg PCNY Pokémon and Egg legality for PCNY Pokémon fixed.
2020-10-07 18:42:14 -07:00
Kurt
e3ef9bbbff
Add current level property for met:X current:Y
2020-10-07 15:35:12 -07:00
Kurt
dad01cb522
Check egg state, reduce verbosity for language type
2020-10-07 15:28:58 -07:00
ShadowMario3
a81e675d26
Update Encounters2.cs ( #3014 )
...
Added the remaining PCNY events. Still need to fix shiny Pokemon where Met Level is 5 but current level is 40, 50, or 70 depending on Pokemon).
2020-10-07 11:43:34 -07:00
Kurt
5d40009a0c
Add multi-OT for es2e, apply special details on enc->pkm
2020-10-07 10:36:28 -07:00
Kurt
61dc9a45ae
Revise Shadow state detection
...
Closes #3012
2020-10-06 22:36:27 -07:00
ShadowMario3
4bae0e823a
Update Encounters2.cs ( #3013 )
...
Started to add some Gen 2 PCNY Event Pokemon and fixed Stadium 2 events.
2020-10-06 22:12:05 -07:00
Kurt
6616996905
Relocate N OT logic
...
Make Legal.cs not care about encounter data :)
2020-10-06 20:09:14 -07:00
Kurt
fe7a4df17e
Clean out some gb era version flagging
2020-10-06 20:05:38 -07:00
Kurt
6e1cbfcfe5
Split GB event types and segregate per VC/GB
...
Handle yielding in the moveset generator as well
Future commits will trim down unused values/abstractions; probably can get all the stadium stuff handled innately
2020-10-06 19:35:03 -07:00
Kurt
3ab824d306
Refactoring
...
Condense some logic
2020-10-06 17:54:17 -07:00
ShadowMario3
1681fc776b
Update Encounters2.cs ( #3011 )
...
Fix Sing Pichu index number.
2020-10-06 10:59:18 -07:00
Kurt
d2fed0d66c
Set party stats on pkm create
...
Party stats are stored in box format
2020-10-05 09:04:32 -07:00
Kurt
aa43904869
Add stad2 boxnames, registered flag handling
2020-10-05 08:29:17 -07:00
Kurt
978305b45e
Fix pp up offset reads
2020-10-04 15:45:21 -07:00
Kurt
d4452ce3af
SK2 coerce to load to a hint language
...
This format won't be supported cleanly, so let's just try to allow language detection to work as best as it can without storing metadata in the SK2 bytes.
2020-10-04 14:42:48 -07:00
Kurt
f4f25da986
Add IsEgg for SK2
...
Stored at 0x1E
2020-10-04 14:15:29 -07:00
Kurt
6938d2f94d
Split VivillonTables into two classes
...
Indicate that the content is for 3DS specific logic
Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
2020-10-04 14:15:13 -07:00
Kurt
b4508846a1
Add test case for eggmove tradeback conundrum
2020-10-04 12:22:33 -07:00
Kurt
36827f795d
Remove gen1 flagged moves if they can originate from egg
...
Revises the tradeback status to remove any index that could have been sourced from egg moves instead.
really should refactor this TradebackStatus away, but Move validation still remains one of the un-refined parts of the legality checks :P
2020-10-04 12:21:05 -07:00
Kurt
757456bf06
Move reset action to class
2020-10-04 12:08:16 -07:00
Kurt
09c6359e3a
Add flexibility for SK2 imports
...
Check language character table for English vs Japanese when loading for a destination
2020-10-04 10:25:34 -07:00
Kurt
f8de9fe1bf
Minor tweaks
...
now that stadium saves all expose registered teams, can just call from the parent class
rental sk2's have no TID; add that to the requirement to not get flagged for missing OT
2020-10-04 09:26:15 -07:00
Kurt
3fd6817a42
Refactoring: Finalize Stadium savefile logic
...
Extract common abstract class for shared logic
Clean up property/field/method ordering to be consistent and logical (roughly: attributes, constructors, state management, retrievable values, static methods)
Apply default language OT name
2020-10-04 09:23:16 -07:00
Kurt
d13b893351
Use PKHeX as blanksav language
...
Closes #3009
Make QRPK7 implement IEncounterable and remove hardcoded PKHeX strings
Let force hatching for WC3 eggs try to hatch from the savefile's language, then revert to english if failed to set an OT.
2020-10-04 08:59:33 -07:00
Kurt
8a7ed99689
Fix s1 team export
...
oops
Add a tostring override to help visually debug
2020-10-04 08:06:44 -07:00
Kurt
fbc4c5038a
Set box metadata on write
...
Fix group export for 1U to exclude the right set of teams
0J now shows the correct amount of boxes & teams (halved)
2020-10-04 07:51:55 -07:00
Kurt
5853888020
Minor Stadium behavior enhancements
...
Use underscores for enum for ToString replacing with spaces
Don't flag empty-OT as SK2; Stadium0/1 use the "TRAINER" as rental, but leave it blank for SK2.
Don't set any terminators for an OT string if the string is empty; just wipe the buffer.
2020-10-03 21:56:57 -07:00
Kurt
262561d5d1
Fix stad1 missing team types
...
off by 1 (8=>9, and EN has unused interstitial teams).
Fix last-viewed-slot indication color tracking
2020-10-03 19:48:56 -07:00
Kurt
7efaa5ab71
Minor clean
...
collapse some expressions
handle some compiler messages
2020-10-03 18:59:36 -07:00
Kurt
816f24e3db
Add Misc pkm array viewer for Stadium saves
...
Readonly slots
Things could be expanded on to use interfaces and wrappers for a "SlotReference" and properties for readonly.
But that's kinda unnecessary
2020-10-03 18:22:29 -07:00