Commit Graph

11351 Commits

Author SHA1 Message Date
Kurt
25e3c4d352 Add Gen1/2=>7 VC pp table & check bypass
ty anubis, santacrab, and Bowarcky for testing & data aggregation

Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: santacrab2 <79347566+santacrab2@users.noreply.github.com>
Co-Authored-By: Bowarcky <54773567+bowarcky@users.noreply.github.com>
2026-06-27 18:02:53 -05:00
Kurt
69ab4e3391 Entree Forest: allow GUI entry of animations 6 & 7
ha ha ha ha ha ha (ha)
Closes #4827
2026-06-25 23:47:51 -05:00
Kurt
8a1e1711eb Misc tweaks
SelectionLength => Select (avoid winapi fetch of SelectionStart), no functional change
Rename DisallowSearch => IsSearchAllowed (check a positive, not a negative)
Fix some stale xmldoc refs
Remove some unused usings
Small preference tweaks (aka resharper yelling at me)
2026-06-25 23:46:16 -05:00
Kurt
17e0b5a707 Add uncaptured differentiation for gen8/9 2026-06-23 02:55:26 -05:00
Kurt
1f556062db Extract common egg location check logic
Handles 658 for mainline-legitimate values (none?), better to be correct.
Adds in a link traded egg checks for unhatched static eggs in Gen6 (previously unchecked)
2026-06-22 23:25:15 -05:00
Kurt
5eb9147e66 HOME: handle BD/SP -1 same as disassembly
BD/SP => HOME sanitizes -1=>0 and 0=>658. HOME is therefore "clean" so the other side-data do not need to know about BD/SP goofiness.
2026-06-22 23:17:54 -05:00
Kurt
fdb5aa2ef8 Update ExperienceBar.cs 2026-06-20 15:14:16 -05:00
Kurt
fff735565c HOME: starter gifts for 8a & 8b fixed scale 2026-06-20 13:48:19 -05:00
Kurt
2fd6d70756 Improve interactivity with exp bar
now supports click+drag, includes tooltip to show remaining exp, % progress, and can hold control to only tooltip current EXP rather than cursor position.
2026-06-20 00:46:18 -05:00
Kurt
9b89c0f330 Misc tweaks
Flag EVs in PLA if no EXP gained (similar to Gen1)
Make exp bar background different from the tab background
Add more "was touched" checks for PLA
remove empty xmldoc declarations
2026-06-19 22:25:57 -05:00
Kurt
4f4227a058 add test cases for fmadd HOME 4.0.0 logic 2026-06-19 20:12:34 -05:00
Kurt
225aa98c5c HOME 4.0.0: handle FMADD size calc optimization
MathF.FusedMultiplyAdd(percent, 0.40000004f, 0.8f);
vs
(percent * 0.40000004f) + 0.8f;
Turns out shiny-Enamorus uses a hardcoded value like Meltan!

sneak in a ball applicator restriction for Shedinja, for DPPt ones to disallow Sport being suggested as OK.
2026-06-19 19:54:56 -05:00
Guillermo Colotti
14d0906386 PA8: fix ExtraBytes unused-offset typos (#4824)
0x018 -> 0x108: 0x18 is the MarkingValue offset (an actively-used
field), so listing it among the "unused" ExtraBytes exposed it in the
byte editor and let edits there clobber the low marking byte (markings
0-3). 0x108 is the byte actually intended in the 0x100-0x10F run.

0xE9 -> 0xEB: the "0xDE-0xEB unused" range listed 0xE9 twice and omitted
0xEB.
2026-06-17 12:46:13 -05:00
sora10pls
18c7570807 Add Champions Ver. 1.1.0 assets 2026-06-17 00:06:35 -04:00
Ka-n00b
55da1121ce Minor updates (#4823) 2026-06-16 00:03:17 -05:00
Kurt
f0a0ac0fa7 HGSS: fix GoodRod-night slotnum
Some edge case staryu reported by bustah2975, thanks dawg
9d25578f79
2026-06-15 23:27:10 -05:00
Coki628
10016c6fe5 translation improvement (#4822) 2026-06-15 08:23:09 -05:00
Kurt
d41aac175f Allow !? for jpn gen2 strings
Closes #4821
not sure this is a perfect solution (traded from gen1=>nicknamed complainers, or iterator prefer-matching gen1 when having !?)
2026-06-14 15:02:00 -05:00
Kurt
bbef47e0bd Localize StatNature => Stat Alignment
bulbapedia's Contest Stat nature amp table for neutral natures is wrong lol
https://bulbapedia.bulbagarden.net/wiki/Contest_condition#Natures
2026-06-14 14:58:40 -05:00
Kurt
3e6895b906 Misc tweaks
Show item sprites for TM/HM in inventory editor, just be more general on the Lumped image method
Rework Trainer ID, now updates tooltip as you change TID. Components are separate controls.
Re-flow Chatter editor GUI
Add Experience bar to pkm editor for more visual editing of the EXP. Matches scroll behavior of EXP/Level textboxes.
Exp bar can be hidden via settings.
2026-06-14 00:51:11 -05:00
Kurt
452ddcb496 Update PK5.cs
didnt bother checking disassembly; this handles basculin if we just use the RefreshAbility API.
2026-06-11 23:47:56 -05:00
Ka-n00b
b5b5c070f7 Translation updates (#4819)
* Update MessageStrings_de.txt

* Update MessageStrings_ko.txt

* Update MessageStrings_es-419.txt

* Update MessageStrings_es.txt

* Update lang_de.txt

* Update lang_en.txt

* Update lang_es-419.txt

* Update lang_es.txt

* Update lang_fr.txt

* Update lang_it.txt

* Update lang_ja.txt

* Update lang_ko.txt

* Update lang_zh-Hans.txt

* Update lang_zh-Hant.txt

* Update lang_es.txt

* Update lang_es-419.txt

* Update lang_fr.txt

* Update lang_it.txt

* Update lang_es-419.txt

* Update lang_es.txt

* Update lang_de.txt
2026-06-11 23:31:44 -05:00
Kurt
65535efa55 Misc tweaks
Reflow inventory editor, gridlines and too-wide sprite column, row select
Make troubleshooting menu items visible for all builds, add localization
Show filename in label for savefile force loader
2026-06-11 23:31:22 -05:00
Manu
27c9bf0b89 PJCS Garchomp (#4820)
Co-authored-by: 9B1td0 <157295620+9B1td0@users.noreply.github.com>
Co-authored-by: Lusamine <30205550+Lusamine@users.noreply.github.com>
2026-06-11 19:28:28 -05:00
Kurt
b7edc12bca Add item sprite to inventory editor 2026-06-11 15:28:40 -05:00
Kurt
c514865082 Gen5: fix basculin-blue reckless ability handling
Closes #2058

so many spots needing updating:
- ability verifier (legality check)
- encounter template=>pk5 (generating)
- editor load abilities (show the ability in list)
- editor save ability (acknowledge ability index)
2026-06-10 23:40:30 -05:00
Kurt
740a3c5b90 Restore preview card on system wake
pc went to sleep, hover preview was missing (minimized?)
this workaround works, maybe I can deduplicate the dllimport in PokePreview, or make this more abstract for future hover card previews like encounters?
2026-06-10 23:19:55 -05:00
Lusamine
a71b808b77 Label SV block for current location ID 2026-06-07 23:50:49 -05:00
Kurt
a052f59ffe Gen5 entree: remove erroneous Invisible flag
was just an impossible form bitflag that causes the game to wig out when set
2026-06-07 18:24:16 -05:00
Kurt
c4d4af2719 Sanity check criteria ability before generating
no more stunlocking the generator by requesting hidden ability mons from wild encounter slots
2026-06-07 17:45:55 -05:00
Kurt
9eb5b4737d gen5: musical prop unlocks as list 2026-06-07 17:15:32 -05:00
Kurt
8cb7a133c5 pk3.Korean always false
even if language ID is hacked to Korean, don't return true (since it doesn't exist).
2026-06-07 17:14:24 -05:00
Kurt
edc6c7c29b Re-flow SAV editor button panels 2026-06-07 16:32:24 -05:00
Kurt
092d760ae9 enc->pk: Minor perf improvement
Move the %25 into the Criteria check method; only done in 1 method rather than across a few dozen.
can potentially skip % operations depending on inputs.

also inline some gender calls where gender isn't needed further in the generation pattern, so it can be skipped.
2026-06-07 16:15:05 -05:00
Kurt
76c3b72ae4 Gen5: Flesh out a few more blocks, PGL editor
Run a quick translation of the save troubleshooter (force loader)
Adds a PGL editor GUI
Fleshes out the adventure info block, GTS block, and battle box block; thanks to the PGL DW effort aggregating over 100 save files to give a varied expression of fields :D
Fix SpriteUtil failing to yield an item sprite (due to the split of artwork-item/big-item, the method was never repointed).

fix wishmkr shiny request failing to return correctly; add in ganlon/salac item set
2026-06-07 15:50:53 -05:00
Ka-n00b
04eb8cbe8b Translation updates (#4816)
* Update legality_de.json

* Update lang_ja.txt

* Update lang_en.txt

* Update lang_es-419.txt

* Update lang_es.txt

* Update lang_fr.txt

* Update lang_it.txt

* Update lang_de.txt

* Update lang_ko.txt

* Update lang_zh-Hans.txt

* Update lang_zh-Hant.txt

* Update lang_zh-Hans.txt

* Update lang_zh-Hant.txt

* Update lang_de.txt

* Update lang_it.txt
2026-06-07 15:05:02 -05:00
Kurt
5767ab85cf Update SAV3RSBox.cs
Closes #4815
ty @MrPerson0
2026-06-04 00:01:53 -05:00
Kurt
d860af34d2 Gen4 korean gts: nickname fallthru case
https: //github.com/kwsch/PKHeX/issues/4811#issuecomment-4612279177
Co-Authored-By: abcboy101 <16735361+abcboy101@users.noreply.github.com>
2026-06-03 23:52:05 -05:00
Kurt
2897b95723 Reduce padding in OT/Misc tab, gen6/7 was too tall 2026-06-02 22:31:20 -05:00
Kurt
7603943e25 Add save file force loader (CTRL-ALT-L)
Accessible on release builds too; now joined by the hex-clipboard &Import and the list-pl&Ugins

maybe I'll add these as a visible toolstrip. for now, feature is available to those in-the-know, and who should know-better.
does this allow loading of previous unsupported romhack savefiles? yeah. should it be used to do that? no.
2026-06-02 00:32:35 -05:00
Kurt
a0328c8330 Misc tweaks
Minor internal api safety to avoid potential memory leaks
2026-06-01 22:25:34 -05:00
Kurt
ff0ad621e3 HGSS: fix pokeathlon trainer name get/set
off by 4 lol
2026-06-01 22:20:46 -05:00
Kurt
57162fa739 Update SpeciesName.cs 2026-05-31 09:51:07 -05:00
Kurt
93661ea50d Update Gen4GlobalTradeRules.cs
Fix comparison to actually indicate Korean GTS exchange required
2026-05-30 23:31:44 -05:00
Kurt
0b6a1accde Minor tweaks
No functional change, extracting some APIs and adding more xmldoc

Store potential learn source group as flags, might change later.
2026-05-30 23:30:51 -05:00
abcboy101
801928d72c Handle KOR Gen2 -> Gen1 transfers (#4814)
Mirror the Korean detection logic in StringConverter2 in StringConverter1
2026-05-30 11:21:47 -05:00
Kurt
0428865d03 Gen4: relax Korean<->International legality
Closes #4811
Follow-up needed (or never):
* OT names: any more?
* OT names: dependent on OT Version/Gender? Dependent on uploader Version/Gender?
* Trigger: on any char being within the Korean chartable span?
* Nicknames: wiped if triggered?
* Trash bytes: if nickname wiped, does it clear correctly? 5-char nickname on Muk would leave 1 char as trash.

Sad this was never common knowledge back in the day.
Add some utility methods to quickly check if sanitization should apply.
2026-05-29 23:50:04 -05:00
Kurt
3aeba927ab Misc tweaks 2026-05-29 15:12:07 -05:00
Ka-n00b
95e1247df1 Minor Translation Updates (#4813)
* Update lang_en.txt

* Update lang_de.txt

* Update lang_es-419.txt

* Update lang_es.txt

* Update lang_fr.txt

* Update lang_it.txt

* Update lang_ja.txt

* Update lang_ko.txt

* Update lang_zh-Hans.txt

* Update lang_zh-Hant.txt

* Update lang_es-419.txt

* Update lang_es.txt

* Update lang_en.txt

* Update lang_zh-Hans.txt

* Update lang_zh-Hant.txt

* Update lang_zh-Hans.txt

* Update lang_zh-Hant.txt

* Update lang_es-419.txt

* Update lang_ko.txt
2026-05-28 22:04:48 -05:00
Kurt
dd76abdbb4 Add highdpi text/control setting, detect dark
Detects for system dark mode on startup since many users don't know about dark mode. Won't override any existing setting, just detects if no cfg exists `new()`.

Text/control dpi scaling is opt-in for high dpi users, reduces font blurriness.
https://github.com/kwsch/PKHeX/discussions/4458#discussioncomment-12362513
The hover-preview was rewritten in the past year to directly paint instead of updating many controls, so it works fine with `DpiUnawareGdiScaled`. I've not checked extensively to see if anything becomes broken, so user beware 💫
2026-05-27 11:28:16 -05:00