Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-10-23 12:13:07 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Expand comboitem loading for simple cases

Browse Source 
slightly less gc pressure, precompute capacity
This commit is contained in:
Kurt
2019-03-18 21:55:33 -07:00
parent 82a40cb965
commit fad5e4bdee
1 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
PKHeX.Core/Util/DataUtil.cs
View File

@@ -248,18 +248,29 @@ public static List<ComboItem> GetUnsortedCBList(string textfile)
.ToList();
}
public static List<ComboItem> GetCBList(IReadOnlyList<string> inStrings, params int[][] allowed)
public static List<ComboItem> GetCBList(IReadOnlyList<string> inStrings)
{
if (allowed.Length == 0)
allowed = new[] { Enumerable.Range(0, inStrings.Count).ToArray() };
return allowed.SelectMany(list => list
.Select(z => new ComboItem { Text = inStrings[z], Value = z })
.OrderBy(z => z.Text))
.ToList();
var list = new List<ComboItem>(inStrings.Count);
var items = inStrings.Select((t, i) => new ComboItem {Text = t, Value = i}).OrderBy(z => z.Text);
list.AddRange(items);
return list;
}
public static void AddCBWithOffset(List<ComboItem> cbList, IReadOnlyList<string> inStrings, int offset, IEnumerable<int> allowed)
public static List<ComboItem> GetCBList(IReadOnlyList<string> inStrings, params int[][] allowed)
{
var count = allowed.Sum(z => z.Length);
var list = new List<ComboItem>(count);
foreach (var arr in allowed)
{
var subset = arr
.Select(z => new ComboItem {Text = inStrings[z], Value = z})
.OrderBy(z => z.Text);
list.AddRange(subset);
}
return list;
}
public static void AddCBWithOffset(List<ComboItem> cbList, IReadOnlyList<string> inStrings, int offset, int[] allowed)
{
var list = allowed
.Select(z => new ComboItem {Text = inStrings[z - offset], Value = z})